Bug 52146

Summary: [WK2] Support for ARM's RVCT compiler in WKBase.h
Product: WebKit Reporter: Siddharth Mathur <s.mathur>
Component: WebKit2Assignee: Siddharth Mathur <s.mathur>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, commit-queue, eric
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: Other   
Bug Depends on:    
Bug Blocks: 50251    
Attachments:
Description Flags
Patch none

Siddharth Mathur
Reported 2011-01-10 07:23:31 PST
Similar to Microsoft's compilers, ARM's RVCT (ARMCC) compiler supports __declspec(dllexport) directive to indicate a DLL export. Update WebKit2/Shared/API/c/WKBase.h to reflect this. Additionally, passing ARMCC the GNU compatbility flag causes the __GNUC__ macro to be implicitly defined, so explicitly guard against use of __attribute__((visibility("default"))).
Attachments
Patch (1.15 KB, patch)
2011-01-10 09:35 PST, Siddharth Mathur 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Siddharth Mathur
Comment 1 2011-01-10 09:35:53 PST
Created attachment 78404 [details] Patch
Eric Seidel (no email)
Comment 2 2011-01-10 11:30:10 PST
Comment on attachment 78404 [details] Patch OK. rs=me.
Eric Seidel (no email)
Comment 3 2011-01-10 11:30:38 PST
CCing Gavin who might know something about ARM.
Gavin Barraclough
Comment 4 2011-01-10 12:06:06 PST
Don't really know anything about this, but would have RS'ed too!
WebKit Commit Bot
Comment 5 2011-01-10 12:06:23 PST
The commit-queue encountered the following flaky tests while processing attachment 78404 [details]: security/block-test-no-port.html bug 52164 (author: pam@chromium.org) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 6 2011-01-10 12:07:45 PST
Comment on attachment 78404 [details] Patch Clearing flags on attachment: 78404 Committed r75404: <http://trac.webkit.org/changeset/75404>
WebKit Commit Bot
Comment 7 2011-01-10 12:07:51 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.