Bug 51761

Summary: bindings/js/JSDesktopNotificationsCustom.cpp is not included in the cmake build
Product: WebKit Reporter: Benjamin Meyer <ben>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, paroga
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: All   
Bug Depends on:    
Bug Blocks: 43906    
Attachments:
Description Flags
proposed solution none

Benjamin Meyer
Reported 2010-12-30 12:16:09 PST
That file is required when NOTIFICATIONS is enabled.
Attachments
proposed solution (1.81 KB, patch)
2010-12-30 12:18 PST, Benjamin Meyer 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Benjamin Meyer
Comment 1 2010-12-30 12:18:20 PST
Created attachment 77694 [details] proposed solution
Patrick R. Gansterer
Comment 2 2010-12-30 12:28:55 PST
LGTM!
WebKit Commit Bot
Comment 3 2010-12-30 12:54:46 PST
Comment on attachment 77694 [details] proposed solution Rejecting attachment 77694 [details] from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=cr-jail-3', 'apply-attachment', '--no-update', '--non-interactive', 77694]" exit_code: 2 Last 500 characters of output: ug. Processing patch 77694 from bug 51761. Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Darin Adler', u'--force']" exit_code: 1 Parsed 2 diffs from patch file(s). patching file WebCore/CMakeLists.txt patching file WebCore/ChangeLog Hunk #1 FAILED at 1. 1 out of 1 hunk FAILED -- saving rejects to file WebCore/ChangeLog.rej Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Darin Adler', u'--force']" exit_code: 1 Full output: http://queues.webkit.org/results/7206278
Patrick R. Gansterer
Comment 4 2010-12-30 13:57:25 PST
Comment on attachment 77694 [details] proposed solution Clearing flags on attachment: 77694 Manually committed r74810: <http://trac.webkit.org/changeset/74810>
Patrick R. Gansterer
Comment 5 2010-12-30 13:58:18 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.