Bug 51280

Summary:

commit-queue should include bot id when attaching failure diffs

Product:

WebKit

Reporter:

Eric Seidel (no email) <eric>

Component:

New Bugs

Assignee:

Eric Seidel (no email) <eric>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, commit-queue, mihaip, ojan

Priority:

Version:

528+ (Nightly build)

Hardware:

Other

OS:

OS X 10.5

Attachments:

Description	Flags
Patch	none
Patch for landing	none
Patch for landing	none

Eric Seidel (no email)

Reported 2010-12-17 16:02:15 PST

commit-queue should include bot id when attaching failure diffs

Attachments
Patch (8.58 KB, patch) 2010-12-17 16:03 PST, Eric Seidel (no email)	no flags	Details Formatted Diff Diff
Patch for landing (8.58 KB, patch) 2010-12-17 23:48 PST, Eric Seidel (no email)	no flags	Details Formatted Diff Diff
Patch for landing (8.46 KB, patch) 2010-12-20 14:27 PST, Eric Seidel (no email)	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Eric Seidel (no email)

Comment 1 2010-12-17 16:03:22 PST

Created attachment 76923 [details] Patch

WebKit Commit Bot

Comment 2 2010-12-17 23:20:46 PST

Comment on attachment 76923 [details] Patch Rejecting attachment 76923 [details] from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=cr-jail-3', 'apply-attachment', '--non-interactive', 76923]" exit_code: 2 Last 500 characters of output: s: -------------------------- |Index: WebKitTools/Scripts/webkitpy/tool/mocktool.py |index 9133b37b2cb0fea3c533c5f70408210f647da632..30a4bc3e983d39e6b02f0b01ebf8971a23ca2c52 100644 |--- WebKitTools/Scripts/webkitpy/tool/mocktool.py |+++ WebKitTools/Scripts/webkitpy/tool/mocktool.py -------------------------- No file to patch. Skipping patch. 2 out of 2 hunks ignored Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Adam Barth', u'--force']" exit_code: 1 Full output: http://queues.webkit.org/results/7267020

Eric Seidel (no email)

Comment 3 2010-12-17 23:48:22 PST

Created attachment 76938 [details] Patch for landing

WebKit Commit Bot

Comment 4 2010-12-17 23:51:22 PST

Comment on attachment 76938 [details] Patch for landing Rejecting attachment 76938 [details] from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=eseidel-cq-sf', 'apply-attachment', '--non-interactive', 76938]" exit_code: 2 Last 500 characters of output: ption? The text leading up to this was: -------------------------- |Index: WebKitTools/Scripts/webkitpy/tool/mocktool.py |index 9133b37b2cb0fea3c533c5f70408210f647da632..30a4bc3e983d39e6b02f0b01ebf8971a23ca2c52 100644 |--- WebKitTools/Scripts/webkitpy/tool/mocktool.py |+++ WebKitTools/Scripts/webkitpy/tool/mocktool.py -------------------------- No file to patch. Skipping patch. 2 out of 2 hunks ignored Failed to run "[u'/Projects/CommitQueue/Tools/Scripts/svn-apply', u'--force']" exit_code: 1 Full output: http://queues.webkit.org/results/7205031

Eric Seidel (no email)

Comment 5 2010-12-20 14:27:41 PST

Created attachment 77036 [details] Patch for landing

WebKit Commit Bot

Comment 6 2010-12-20 15:56:08 PST

Comment on attachment 77036 [details] Patch for landing Clearing flags on attachment: 77036 Committed r74373: <http://trac.webkit.org/changeset/74373>

WebKit Commit Bot

Comment 7 2010-12-20 15:56:16 PST

All reviewed patches have been landed. Closing bug.

WebKit Commit Bot

Comment 8 2010-12-20 16:14:29 PST

The commit-queue encountered the following flaky tests while processing attachment 77036 [details]: inspector/debugger-eval-on-call-frame.html bug 51361 (author: yurys@chromium.org) fast/loader/recursive-before-unload-crash.html bug 50880 (authors: beidson@apple.com and eric@webkit.org) The commit-queue is continuing to process your patch.

Note You need to log in before you can comment on or make changes to this bug.