Bug 51044

Summary: [V8] Get rid of delayed exception reporting in V8ConsoleMessage.cpp
Product: WebKit Reporter: Yury Semikhatsky <yurys>
Component: WebCore Misc.Assignee: Yury Semikhatsky <yurys>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, antonm, pfeldman
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Bug Depends on: 8519    
Bug Blocks:    
Attachments:
Description Flags
Patch
abarth: review+, abarth: commit-queue-
Patch that I'm going to land. none

Yury Semikhatsky
Reported 2010-12-14 10:22:07 PST
Get rid of delayed exception reporting in V8ConsoleMessage.cpp. All exceptions/errors can be reported immediately.
Attachments
Patch (22.76 KB, patch)
2010-12-14 10:26 PST, Yury Semikhatsky 		abarth: review+
abarth: commit-queue-
DetailsFormatted DiffDiff
Patch that I'm going to land. (22.25 KB, patch)
2011-01-20 04:25 PST, Yury Semikhatsky 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Yury Semikhatsky
Comment 1 2010-12-14 10:26:56 PST
Created attachment 76545 [details] Patch
Adam Barth
Comment 2 2010-12-14 12:20:05 PST
Comment on attachment 76545 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=76545&action=review Great. I'm glad to be rid of this complexity. > WebCore/bindings/v8/V8DOMWindowShell.cpp:102 > + Document* document = frame->document(); > + if (!document) > + return; document can never be null. > WebCore/bindings/v8/V8DOMWindowShell.cpp:116 > + String resourceNameString = useURL ? frame->document()->url() : toWebCoreString(resourceName); You've already got document in a local variable. No need to go back to the Frame.
Yury Semikhatsky
Comment 3 2011-01-20 04:25:01 PST
Created attachment 79578 [details] Patch that I'm going to land. All comments have been addressed.
Yury Semikhatsky
Comment 4 2011-01-20 04:31:50 PST
Committed r76224: <http://trac.webkit.org/changeset/76224>
Note You need to log in before you can comment on or make changes to this bug.