Bug 50973

Summary: Move SliderThumbElement into its own file
Product: WebKit Reporter: Dimitri Glazkov (Google) <dglazkov>
Component: DOMAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, buildbot, eric, gustavo, levin, webkit-ews, webkit.review.bot, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 44907    
Attachments:
Description Flags
Patch
none
Patch
none
Hopefully everything builds now. levin: review+

Dimitri Glazkov (Google)
Reported 2010-12-13 14:12:56 PST
In preparation for converting it to the right-side-up shadow DOM.
Attachments
Patch (20.89 KB, patch)
2010-12-13 16:40 PST, Dimitri Glazkov (Google) 		no flags
DetailsFormatted DiffDiff
Patch (21.58 KB, patch)
2010-12-14 09:09 PST, Dimitri Glazkov (Google) 		no flags
DetailsFormatted DiffDiff
Hopefully everything builds now. (28.34 KB, patch)
2010-12-14 10:16 PST, Dimitri Glazkov (Google) 		levin: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Dimitri Glazkov (Google)
Comment 1 2010-12-13 16:40:44 PST
Created attachment 76466 [details] Patch
WebKit Review Bot
Comment 2 2010-12-13 17:41:09 PST
Attachment 76466 [details] did not build on gtk: Build output: http://queues.webkit.org/results/6934110
Build Bot
Comment 3 2010-12-13 17:45:19 PST
Attachment 76466 [details] did not build on win: Build output: http://queues.webkit.org/results/6909112
Early Warning System Bot
Comment 4 2010-12-13 18:20:32 PST
Attachment 76466 [details] did not build on qt: Build output: http://queues.webkit.org/results/7043026
David Levin
Comment 5 2010-12-13 19:35:15 PST
Comment on attachment 76466 [details] Patch Due to broken builds.
Dimitri Glazkov (Google)
Comment 6 2010-12-14 09:09:18 PST
Created attachment 76541 [details] Patch
Dimitri Glazkov (Google)
Comment 7 2010-12-14 09:43:04 PST
Comment on attachment 76541 [details] Patch still need to fix win.
Build Bot
Comment 8 2010-12-14 09:54:26 PST
Attachment 76541 [details] did not build on win: Build output: http://queues.webkit.org/results/6999113
Dimitri Glazkov (Google)
Comment 9 2010-12-14 10:16:04 PST
Created attachment 76544 [details] Hopefully everything builds now.
Dimitri Glazkov (Google)
Comment 10 2010-12-14 10:40:32 PST
Yay, all builds! David, can haz r+?
Dimitri Glazkov (Google)
Comment 11 2010-12-14 11:30:35 PST
Committed r74044: <http://trac.webkit.org/changeset/74044>
WebKit Review Bot
Comment 12 2010-12-14 11:39:48 PST
http://trac.webkit.org/changeset/74044 might have broken GTK Linux 64-bit Debug
Dimitri Glazkov (Google)
Comment 13 2010-12-15 20:50:32 PST
(In reply to comment #12) > http://trac.webkit.org/changeset/74044 might have broken GTK Linux 64-bit Debug GTK Fixed in http://trac.webkit.org/changeset/74047.
Note You need to log in before you can comment on or make changes to this bug.