Bug 50849

Summary: [Qt] StillImage::draw() should use ContextShadow
Product: WebKit Reporter: Helder Correia <helder>
Component: CanvasAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, eric, mdelaney7, ossy, pfeldman
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Bug Depends on: 34479    
Bug Blocks:    
Attachments:
Description Flags
Patch none

Helder Correia
Reported 2010-12-10 15:19:42 PST
The branch that checks for a shadow requirement in StillImage::draw() is executed when drawing a canvas onto a canvas with ctx1.drawImage(canvas2, x, y). The current implementation supports solid shadows only. And if transformations are present, the offset gets transformed as well. Thus, ContextShadow must be used instead in order to support blur and correct offset transformations.
Attachments
Patch (10.52 KB, patch)
2010-12-10 15:24 PST, Helder Correia 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Helder Correia
Comment 1 2010-12-10 15:24:29 PST
Created attachment 76268 [details] Patch
Eric Seidel (no email)
Comment 2 2010-12-13 00:17:43 PST
Comment on attachment 76268 [details] Patch LGTM. Assuming your test case failed before this change.
WebKit Commit Bot
Comment 3 2010-12-13 00:56:43 PST
Comment on attachment 76268 [details] Patch Clearing flags on attachment: 76268 Committed r73889: <http://trac.webkit.org/changeset/73889>
WebKit Commit Bot
Comment 4 2010-12-13 00:56:49 PST
All reviewed patches have been landed. Closing bug.
Eric Seidel (no email)
Comment 5 2010-12-13 11:15:43 PST
pfeldman seems to believe this caused failures on cr win/linux: http://code.google.com/p/chromium/issues/detail?id=66683 That seems unlikely/impossible.
Pavel Feldman
Comment 6 2010-12-14 04:43:00 PST
(In reply to comment #5) > pfeldman seems to believe this caused failures on cr win/linux: > http://code.google.com/p/chromium/issues/detail?id=66683 > That seems unlikely/impossible. Well, the new test introduced with this commit does not pass on chromium. Why unlikely/impossible? Please follow the link to find the failure details: http://test-results.appspot.com/dashboards/flakiness_dashboard.html#master=ChromiumWebkit&tests=canvas-draw-canvas-on-canvas-shadow.html Click "Show results" link and also click the rightmost vertical red bar in the test timeline to see the commit that caused the regression. It this case it is http://trac.webkit.org/changeset/73889 that you reviewed.
Note You need to log in before you can comment on or make changes to this bug.