Bug 50545

Summary: [chromium] Upstream skia/ImageBuffer.cpp routine mulDiv255Ceil()
Product: WebKit Reporter: noel gordon <noel.gordon>
Component: CanvasAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov, eric, mdelaney7, senorblanco, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Windows 7   
Attachments:
Description Flags
patch
none
patch try linux ews again
eric: review+
patch try linux ews take 2 none

noel gordon
Reported 2010-12-05 15:26:07 PST
As mentioned on bug 49365, we should upstream mulDiv255Ceil() to the skia repository.
Attachments
patch (2.38 KB, patch)
2010-12-08 17:24 PST, noel gordon 		no flags
DetailsFormatted DiffDiff
patch try linux ews again (2.38 KB, patch)
2010-12-09 20:49 PST, noel gordon 		eric: review+
DetailsFormatted DiffDiff
patch try linux ews take 2 (2.38 KB, patch)
2010-12-13 19:56 PST, noel gordon 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
noel gordon
Comment 1 2010-12-06 16:15:02 PST
patch sent http://codereview.appspot.com/3466042
noel gordon
Comment 2 2010-12-07 15:13:39 PST
landed http://code.google.com/p/skia/source/detail?r=632
noel gordon
Comment 3 2010-12-08 17:23:11 PST
skia rolled into chrome http://src.chromium.org/viewvc/chrome?view=rev&revision=68558
noel gordon
Comment 4 2010-12-08 17:24:01 PST
Created attachment 75991 [details] patch
noel gordon
Comment 5 2010-12-08 19:24:09 PST
test_shell is happy before and after this patch
WebKit Review Bot
Comment 6 2010-12-09 01:14:49 PST
Attachment 75991 [details] did not build on chromium: Build output: http://queues.webkit.org/results/6959004
noel gordon
Comment 7 2010-12-09 20:48:20 PST
Checked out chromium & webkit ToT, built chromium linux debug/release with the patch fine.
noel gordon
Comment 8 2010-12-09 20:49:19 PST
Created attachment 76160 [details] patch try linux ews again
WebKit Review Bot
Comment 9 2010-12-09 20:58:02 PST
Attachment 76160 [details] did not build on chromium: Build output: http://queues.webkit.org/results/6912020
noel gordon
Comment 10 2010-12-09 21:59:27 PST
waiting on EWS and chrome trys to update their chromium DEPS
Eric Seidel (no email)
Comment 11 2010-12-09 23:56:54 PST
Comment on attachment 76160 [details] patch try linux ews again LGTM.
Eric Seidel (no email)
Comment 12 2010-12-13 00:22:42 PST
Sadly we currently have no way to cause the EWS to retry other than to upload a new patch. :(
noel gordon
Comment 13 2010-12-13 18:49:40 PST
Understood, once bug 50984 lands, I will upload again.
noel gordon
Comment 14 2010-12-13 19:56:21 PST
Created attachment 76488 [details] patch try linux ews take 2 resending.
WebKit Review Bot
Comment 15 2010-12-13 20:32:44 PST
The commit-queue encountered the following flaky tests while processing attachment 76488 [details]: inspector/elements-panel-styles.html bug 50987 (author: pfeldman@chromium.org) animations/suspend-resume-animation.html bug 51004 (author: cmarrin@apple.com) The commit-queue is continuing to process your patch.
WebKit Review Bot
Comment 16 2010-12-13 20:47:51 PST
Comment on attachment 76488 [details] patch try linux ews take 2 Clearing flags on attachment: 76488 Committed r73997: <http://trac.webkit.org/changeset/73997>
WebKit Review Bot
Comment 17 2010-12-13 20:47:57 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.