Bug 50440

Summary: Finish splitting DECLARE_ANIMATED_PROPERTY* in DECLARE/DEFINE parts for the remaining SVGAnimated* types
Product: WebKit Reporter: Nikolas Zimmermann <zimmermann>
Component: SVGAssignee: Nikolas Zimmermann <zimmermann>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, dglazkov, webkit-ews, webkit.review.bot, zimmermann
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Bug Depends on: 50316    
Bug Blocks: 42025    
Attachments:
Description Flags
Patch
none
Patch v2 krit: review+

Nikolas Zimmermann
Reported 2010-12-03 00:43:57 PST
Same work as bug 50316, but for SVGAnimatedBoolean/SVGAnimatedAngle/SVGAnimatedRect. This marks the end of the split patch series. After this lands the global SVGNames.h include problem can be fixed.
Attachments
Patch (93.04 KB, patch)
2010-12-03 00:47 PST, Nikolas Zimmermann 		no flags
DetailsFormatted DiffDiff
Patch v2 (93.69 KB, patch)
2010-12-03 01:27 PST, Nikolas Zimmermann 		krit: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Nikolas Zimmermann
Comment 1 2010-12-03 00:47:19 PST
Created attachment 75470 [details] Patch
Early Warning System Bot
Comment 2 2010-12-03 01:04:39 PST
Attachment 75470 [details] did not build on qt: Build output: http://queues.webkit.org/results/6781023
WebKit Review Bot
Comment 3 2010-12-03 01:11:00 PST
Attachment 75470 [details] did not build on chromium: Build output: http://queues.webkit.org/results/6753025
Dirk Schulze
Comment 4 2010-12-03 01:11:39 PST
Comment on attachment 75470 [details] Patch LGTM. Please fix the style error, if there is one. Don't you use webkit upload? If not, please check the style with check-webkit-style before you commit a patch - always. r=me
Dirk Schulze
Comment 5 2010-12-03 01:12:46 PST
Comment on attachment 75470 [details] Patch Clearing r+ because of build breaks on some bots.
Build Bot
Comment 6 2010-12-03 01:26:02 PST
Attachment 75470 [details] did not build on win: Build output: http://queues.webkit.org/results/6805023
Nikolas Zimmermann
Comment 7 2010-12-03 01:27:51 PST
Created attachment 75473 [details] Patch v2
Dirk Schulze
Comment 8 2010-12-03 01:39:19 PST
Comment on attachment 75473 [details] Patch v2 r=me
Nikolas Zimmermann
Comment 9 2010-12-03 01:45:14 PST
Landed in r73254.
Note You need to log in before you can comment on or make changes to this bug.