Bug 50257

Summary: [Qt] [WK2] Build system improvements for non-Unix targets
Product: WebKit Reporter: Siddharth Mathur <s.mathur>
Component: WebKit2Assignee: Siddharth Mathur <s.mathur>
Status: RESOLVED FIXED    
Severity: Minor CC: commit-queue, laszlo.gombos
Priority: P3 Keywords: Qt
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 50251    
Attachments:
Description Flags
Fix directory seperators for Windows as host
none
Updated patch for Windows build host and ARMCC flag
laszlo.gombos: review-
updated patch with only changes requested by Laszlo none

Siddharth Mathur
Reported 2010-11-30 11:51:48 PST
Fixes to .pro/.pri files for non-Linux based Qt platforms.
Attachments
Fix directory seperators for Windows as host (2.51 KB, patch)
2010-11-30 15:36 PST, Siddharth Mathur 		no flags
DetailsFormatted DiffDiff
Updated patch for Windows build host and ARMCC flag (4.54 KB, patch)
2010-11-30 17:14 PST, Siddharth Mathur 		laszlo.gombos: review-
DetailsFormatted DiffDiff
updated patch with only changes requested by Laszlo (2.54 KB, patch)
2010-12-03 11:41 PST, Siddharth Mathur 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Siddharth Mathur
Comment 1 2010-11-30 15:36:05 PST
Created attachment 75218 [details] Fix directory seperators for Windows as host
Siddharth Mathur
Comment 2 2010-11-30 17:14:51 PST
Created attachment 75236 [details] Updated patch for Windows build host and ARMCC flag
Laszlo Gombos
Comment 3 2010-12-01 05:59:45 PST
Comment on attachment 75236 [details] Updated patch for Windows build host and ARMCC flag This patch does not seems to apply cleanly to the trunk, r- for that. Also, have you successfully used --preinclude in any environment ? If not than this code is speculative and I think we should not land it until we used it successfully. Perhaps you can resolve the conflict with the trunk and resubmit the patch without the "--preinclude" changes.
Siddharth Mathur
Comment 4 2010-12-03 11:41:10 PST
Created attachment 75519 [details] updated patch with only changes requested by Laszlo
Laszlo Gombos
Comment 5 2010-12-03 13:03:12 PST
Comment on attachment 75519 [details] updated patch with only changes requested by Laszlo looks great, thanks. r+.
WebKit Commit Bot
Comment 6 2010-12-03 15:35:15 PST
Comment on attachment 75519 [details] updated patch with only changes requested by Laszlo Clearing flags on attachment: 75519 Committed r73313: <http://trac.webkit.org/changeset/73313>
WebKit Commit Bot
Comment 7 2010-12-03 15:35:20 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.