Bug 49368

Summary: Philip canvas test 2d.drawImage.null fails
Product: WebKit Reporter: Helder Correia <helder>
Component: CanvasAssignee: Nobody <webkit-unassigned>
Status: RESOLVED DUPLICATE    
Severity: Normal CC: commit-queue, mdelaney7
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
URL: http://philip.html5.org/tests/canvas/suite/tests/2d.drawImage.null.html
Bug Depends on:    
Bug Blocks: 46506    
Attachments:
Description Flags
Patch kling: review+, commit-queue: commit-queue-

Helder Correia
Reported 2010-11-11 00:42:18 PST
A TYPE_MISMATCH_ERR DOM exception must be thrown if the image is of the wrong type or null.
Attachments
Patch (4.62 KB, patch)
2010-11-11 00:47 PST, Helder Correia 		kling: review+
commit-queue: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Helder Correia
Comment 1 2010-11-11 00:47:11 PST
Created attachment 73587 [details] Patch
Andreas Kling
Comment 2 2010-11-11 03:02:01 PST
Comment on attachment 73587 [details] Patch r=me
WebKit Commit Bot
Comment 3 2010-11-11 06:34:16 PST
Comment on attachment 73587 [details] Patch Rejecting patch 73587 from commit-queue. Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=eseidel-cq-sl', 'apply-attachment', '--force-clean', '--non-interactive', 73587]" exit_code: 2 Last 500 characters of output: g file LayoutTests/platform/qt/Skipped patching file WebCore/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file WebCore/bindings/js/JSCanvasRenderingContext2DCustom.cpp Hunk #1 succeeded at 281 with fuzz 2 (offset 86 lines). Hunk #2 FAILED at 355. 1 out of 2 hunks FAILED -- saving rejects to file WebCore/bindings/js/JSCanvasRenderingContext2DCustom.cpp.rej Failed to run "[u'/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', u'--reviewer', u'Andreas Kling', u'--force']" exit_code: 1 Full output: http://queues.webkit.org/results/5546095
Matthew Delaney
Comment 4 2010-11-11 06:47:18 PST
This fix should break other current test expectations that assume that the TypeError will be thrown because of the (non-null) invalid parameters as per the WebIDL spec (as noted by Philip in your other patch from last night) such as the test 2d.drawImage,wrongTypes (or something like that name). Did nothing fail when you ran the layout tests? Also, a few hours earlier: https://bugs.webkit.org/show_bug.cgi?id=48307
Helder Correia
Comment 5 2010-11-11 12:41:23 PST
(In reply to comment #4) > Did nothing fail when you ran the layout tests? Hmm, looks like I only ran the fast canvas tests, my bad. > Also, a few hours earlier: https://bugs.webkit.org/show_bug.cgi?id=48307 Heh, better try to sync with you on IRC next time :) Thanks, Matthew, I'll mark this as a duplicate.
Helder Correia
Comment 6 2010-11-11 12:41:40 PST
*** This bug has been marked as a duplicate of bug 48307 ***
Note You need to log in before you can comment on or make changes to this bug.