Bug 49285

Summary: [Chromium/DRT] Make EventSendingController send complete touch events.
Product: WebKit Reporter: Robert Kroeger <rjkroege>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
p1 for 49285
none
Addressed review comments. none

Robert Kroeger
Reported 2010-11-09 15:37:19 PST
The forthcoming patch makes EventSendingController send touch events more like how it currently handles mouse events: it gives them valid screenPosition fields and does layout before dispatching them.
Attachments
p1 for 49285 (2.25 KB, patch)
2010-11-10 10:35 PST, Robert Kroeger 		no flags
DetailsFormatted DiffDiff
Addressed review comments. (2.07 KB, patch)
2010-11-10 12:36 PST, Robert Kroeger 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Robert Kroeger
Comment 1 2010-11-10 10:35:02 PST
Created attachment 73505 [details] p1 for 49285
James Robinson
Comment 2 2010-11-10 11:59:21 PST
Comment on attachment 73505 [details] p1 for 49285 View in context: https://bugs.webkit.org/attachment.cgi?id=73505&action=review Patch looks good, but please fix/remove the comment before landing. > WebKitTools/DumpRenderTree/chromium/EventSender.cpp:878 > + // Force a layout here just to make sure every position has been > + // determined before we send events (as well as all the other methods > + // that send an event do). This comment doesn't seem very helpful, I'd just leave it out. It's also not entirely accurate from what I can tell (it won't change the position argument passed on this event).
Robert Kroeger
Comment 3 2010-11-10 12:36:19 PST
Created attachment 73527 [details] Addressed review comments.
Eric Seidel (no email)
Comment 4 2010-11-10 14:01:11 PST
Comment on attachment 73505 [details] p1 for 49285 Cleared James Robinson's review+ from obsolete attachment 73505 [details] so that this bug does not appear in http://webkit.org/pending-commit.
James Robinson
Comment 5 2010-11-11 13:48:55 PST
Comment on attachment 73527 [details] Addressed review comments. Cool!
WebKit Commit Bot
Comment 6 2010-11-11 14:37:35 PST
Comment on attachment 73527 [details] Addressed review comments. Rejecting patch 73527 from commit-queue. Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=abarth-cq-sl', 'build', '--no-clean', '--no-update', '--build-style=both']" exit_code: 1 ERROR: Working directory has local commits, pass --force-clean to continue. Full output: http://queues.webkit.org/results/5744004
WebKit Commit Bot
Comment 7 2010-11-12 09:43:27 PST
Comment on attachment 73527 [details] Addressed review comments. Clearing flags on attachment: 73527 Committed r71921: <http://trac.webkit.org/changeset/71921>
WebKit Commit Bot
Comment 8 2010-11-12 09:43:32 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.