Bug 49101

Summary: [Web Timing] Add unloadEventStart
Product: WebKit Reporter: Tony Gentilcore <tonyg>
Component: WebCore Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dglazkov, eric, fishd, simonjam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
URL: http://dvcs.w3.org/hg/webperf/raw-file/tip/specs/NavigationTiming/Overview.html#nt-unload-start
Bug Depends on:    
Bug Blocks: 30685, 48922    
Attachments:
Description Flags
Patch
none
Patch
fishd: review+, fishd: commit-queue-
Patch
fishd: review+, commit-queue: commit-queue-
Patch none

Attachments
Patch (16.00 KB, patch)
2010-11-08 22:29 PST, James Simonsen 		no flags
DetailsFormatted DiffDiff
Patch (17.08 KB, patch)
2010-11-16 16:34 PST, James Simonsen 		fishd: review+
fishd: commit-queue-
DetailsFormatted DiffDiff
Patch (17.05 KB, patch)
2010-11-17 11:35 PST, James Simonsen 		fishd: review+
commit-queue: commit-queue-
DetailsFormatted DiffDiff
Patch (17.05 KB, patch)
2010-11-18 12:35 PST, James Simonsen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
James Simonsen
Comment 1 2010-11-08 22:29:42 PST
Created attachment 73342 [details] Patch
James Simonsen
Comment 2 2010-11-16 16:34:14 PST
Created attachment 74057 [details] Patch
James Simonsen
Comment 3 2010-11-16 16:34:41 PST
Merged with my other recent patches.
Tony Gentilcore
Comment 4 2010-11-17 11:22:00 PST
LGTM Fishing for reviewers :-)
Darin Fisher (:fishd, Google)
Comment 5 2010-11-17 11:25:24 PST
Comment on attachment 74057 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=74057&action=review > WebCore/page/DOMWindow.h:278 > + void dispatchWebTimedEvent(PassRefPtr<Event> event, Document* target, double* startTime, double* endTime); actually, i'd probably just call this dispatchTimedEvent.
James Simonsen
Comment 6 2010-11-17 11:35:47 PST
Created attachment 74139 [details] Patch
Darin Fisher (:fishd, Google)
Comment 7 2010-11-18 09:42:10 PST
Comment on attachment 74139 [details] Patch Thanks!
WebKit Commit Bot
Comment 8 2010-11-18 10:55:56 PST
Comment on attachment 74139 [details] Patch Rejecting patch 74139 from commit-queue. Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=eseidel-cq-sl', 'build', '--no-clean', '--no-update', '--build-style=both']" exit_code: 2 Last 500 characters of output: cts-normal/x86_64/ScriptController.o /Projects/CommitQueue/WebCore/bindings/js/ScriptController.cpp normal x86_64 c++ com.apple.compilers.gcc.4_2 CompileC /Projects/CommitQueue/WebKitBuild/WebCore.build/Debug/WebCore.build/Objects-normal/x86_64/ScriptDebugServer.o /Projects/CommitQueue/WebCore/bindings/js/ScriptDebugServer.cpp normal x86_64 c++ com.apple.compilers.gcc.4_2 (12 failures) Use of uninitialized value $_[0] in join or string at /System/Library/Perl/5.10.0/File/Spec/Unix.pm line 81. Full output: http://queues.webkit.org/results/6260014
James Simonsen
Comment 9 2010-11-18 12:35:53 PST
Created attachment 74278 [details] Patch
James Simonsen
Comment 10 2010-11-18 12:36:59 PST
I wasn't able to reproduce that failure. Just to be safe, I uploaded a new patch after pulling in the latest changes and merging. Can someone set CQ+ again?
WebKit Commit Bot
Comment 11 2010-11-19 10:18:09 PST
The commit-queue encountered the following flaky tests while processing attachment 74278 [details]: inspector/timeline-layout.html Please file bugs against the tests. These tests were authored by pfeldman@chromium.org and yurys@chromium.org. The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 12 2010-11-19 10:19:48 PST
Comment on attachment 74278 [details] Patch Clearing flags on attachment: 74278 Committed r72415: <http://trac.webkit.org/changeset/72415>
Eric Seidel (no email)
Comment 13 2010-12-14 01:39:35 PST
Looks like this got landed and can be closed, no? You should consider usign webkit-patch upload to upload patches as it will correctly obsolete old patches when uploading new ones.
Note You need to log in before you can comment on or make changes to this bug.