Bug 48922

Summary: [Web Timing] Remove vendor prefix
Product: WebKit Reporter: Tony Gentilcore <tonyg>
Component: WebCore Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, commit-queue, fishd, mjs, peter, simonjam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
URL: http://test.w3.org/webperf/specs/NavigationTiming/
Bug Depends on: 46301, 48919, 48920, 49101, 50943, 51200    
Bug Blocks: 30685, 48923    
Attachments:
Description Flags
Patch
none
Patch
none
Patch for landing none

Tony Gentilcore
Reported 2010-11-03 09:45:41 PDT
Rename window.webkitPerformance to window.performance. The Navigation Timing specification is at Draft stage, has two implementations (WebKit and IE) and we have tentatively agreed in the public-web-perf working group to move the spec to last call by end of November 2010. It is probably time to think about removing the vendor prefix.
Attachments
Patch (14.53 KB, patch)
2010-11-08 17:45 PST, James Simonsen 		no flags
DetailsFormatted DiffDiff
Patch (15.60 KB, patch)
2010-12-16 13:17 PST, James Simonsen 		no flags
DetailsFormatted DiffDiff
Patch for landing (21.08 KB, patch)
2011-01-06 11:30 PST, James Simonsen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
James Simonsen
Comment 1 2010-11-08 17:45:03 PST
Created attachment 73322 [details] Patch
Tony Gentilcore
Comment 2 2010-11-08 17:56:11 PST
Let's hold off on landing this until the 3 bugs that this depends on are fixed. Then I believe we are completely in compliance with the spec and can remove the prefix. Just in case I missed something, James, you might want to do a quick pass over the spec just to verify that we are done. Adam, once that is done, do you feel comfortable approving this? Is there anyone else we should check with?
Adam Barth
Comment 3 2010-11-08 19:50:51 PST
Comment on attachment 73322 [details] Patch I'm following this spec that closely, but I know that you all are.
Tony Gentilcore
Comment 4 2010-11-17 09:37:47 PST
This patch LGTM. I took another pass over the spec to check that we are all in compliance. After bug 49101, this should be ready to go. We discussed in the working group this morning that if this can land by the end of the year, it will allow us to move forward in the w3c process to that point that will allow Web Timing to be included in the final shipping IE9. We should help make sure that can happen. Darin, do you have any thoughts on removing the vendor prefix?
Darin Fisher (:fishd, Google)
Comment 5 2010-11-18 09:04:59 PST
What about Mozilla's plans? How far are they from implementing this spec?
Tony Gentilcore
Comment 6 2010-11-18 09:17:54 PST
(In reply to comment #5) > What about Mozilla's plans? How far are they from implementing this spec? Jonas has been participating in the working group list and calls. There was a patch to start landing, but now it appears abandoned and ownerless: https://bugzilla.mozilla.org/show_bug.cgi?id=570341 Sigbjørn from Opera has also recently starting taking an interest in the list discussions, but I don't know the status of their implementation (if any). The latest IE9 beta is in complete compliance w/ the spec (except for the ms prefix).
James Simonsen
Comment 7 2010-12-16 12:09:51 PST
New requirement: window.performance should be replaceable.
James Simonsen
Comment 8 2010-12-16 13:17:06 PST
Created attachment 76806 [details] Patch
Tony Gentilcore
Comment 9 2010-12-16 14:24:10 PST
I'm going to mark the two bugs we found from the IE test suite as blocking this. We should only remove the prefix when it is perfect.
Tony Gentilcore
Comment 10 2011-01-04 11:24:03 PST
Now that the interface is replaceable and all the blocking bugs are fixed, this looks good to me.
WebKit Commit Bot
Comment 11 2011-01-05 09:35:44 PST
Comment on attachment 76806 [details] Patch Rejecting attachment 76806 [details] from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=eseidel-sf-cq', 'apply-attachment', '--no-update', '--non-interactive', 76806]" exit_code: 2 Last 500 characters of output: patching file WebCore/page/DOMWindow.cpp patching file WebCore/page/DOMWindow.h Hunk #1 succeeded at 405 (offset 3 lines). patching file WebCore/page/DOMWindow.idl Hunk #1 succeeded at 222 (offset 1 line). patching file WebKit/chromium/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file WebKit/chromium/src/WebFrameImpl.cpp Hunk #1 succeeded at 713 (offset 1 line). Failed to run "[u'/Projects/CommitQueue/Tools/Scripts/svn-apply', u'--reviewer', u'Darin Fisher', u'--force']" exit_code: 1 Full output: http://queues.webkit.org/results/7347052
James Simonsen
Comment 12 2011-01-06 11:30:31 PST
Created attachment 78137 [details] Patch for landing
WebKit Commit Bot
Comment 13 2011-01-06 14:39:52 PST
Comment on attachment 78137 [details] Patch for landing Clearing flags on attachment: 78137 Committed r75200: <http://trac.webkit.org/changeset/75200>
WebKit Commit Bot
Comment 14 2011-01-06 14:39:59 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.