Bug 48522

Summary: fast/text/international/bidi-linebreak*.html Layout tests broken
Product: WebKit Reporter: Jeremy Moskovich <playmobil>
Component: WebCore Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, commit-queue, mitz, rniwa, xji
Priority: P1 Keywords: LayoutTestFailure, Regression
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: OS X 10.5   
Attachments:
Description Flags
Results of bidi-linebreak-001 on ToT .
none
Patch none

Jeremy Moskovich
Reported 2010-10-28 07:08:47 PDT
bidi-linebreak-001.html, bidi-linebreak-002.html & bidi-linebreak-003.html have regressed on ToT. Other browsers: Safari 5.0.1: OK WebKit nightly r70618: FAIL
Attachments
Results of bidi-linebreak-001 on ToT . (16.91 KB, image/png)
2010-10-28 07:10 PDT, Jeremy Moskovich 		no flags
Details
Patch (1.42 KB, patch)
2011-03-03 11:46 PST, Jeremy Moskovich 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Jeremy Moskovich
Comment 1 2010-10-28 07:10:18 PDT
Created attachment 72186 [details] Results of bidi-linebreak-001 on ToT .
mitz
Comment 2 2010-10-28 07:13:21 PDT
I think this bug is invalid. Adam Barth can confirm. See r61234.
Jeremy Moskovich
Comment 3 2010-10-28 07:43:47 PDT
Thanks for tracking that down Mitz.
Adam Barth
Comment 4 2010-10-28 10:39:10 PDT
Yeah, this test doesn't test what it intends anymore because the HTML5 parser normalizes some of the whitespace to other characters.
Jeremy Moskovich
Comment 5 2010-10-28 10:57:07 PDT
Does it make sense to remove or annotate the tests?
Adam Barth
Comment 6 2010-10-28 13:45:15 PDT
Sure, that seems like a good idea.
Jeremy Moskovich
Comment 7 2011-03-03 11:45:17 PST
Reopening so we can add some documentation on why the tests are failing.
Jeremy Moskovich
Comment 8 2011-03-03 11:46:03 PST
Created attachment 84600 [details] Patch
Dimitri Glazkov (Google)
Comment 9 2011-03-03 11:47:40 PST
Comment on attachment 84600 [details] Patch k
WebKit Commit Bot
Comment 10 2011-03-03 20:53:35 PST
The commit-queue encountered the following flaky tests while processing attachment 84600 [details]: security/block-test.html bug 55741 (authors: beidson@apple.com, mrowe@apple.com, and sam@webkit.org) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 11 2011-03-03 20:55:39 PST
Comment on attachment 84600 [details] Patch Clearing flags on attachment: 84600 Committed r80316: <http://trac.webkit.org/changeset/80316>
WebKit Commit Bot
Comment 12 2011-03-03 20:55:45 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.