Bug 48223

Summary: [Qt] Update the baseline for blur shadow test
Product: WebKit Reporter: Ariya Hidayat <ariya.hidayat>
Component: Layout and RenderingAssignee: Ariya Hidayat <ariya.hidayat>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, eric, kling
Priority: P2 Keywords: HTML5, Qt, QtTriaged
Version: 528+ (Nightly build)   
Hardware: PC   
OS: All   
Bug Depends on:    
Bug Blocks: 34479, 46327    
Attachments:
Description Flags
Patch
none
Correct box-shadow behavior when using blur and border-radius.
ariya.hidayat: review-
Correct basic-shadows line segments. none

Ariya Hidayat
Reported 2010-10-25 00:26:04 PDT
After the blur radius fix in r68145, blur shadow test needs a new baseline.
Attachments
Patch (53.58 KB, patch)
2010-10-25 00:50 PDT, Ariya Hidayat 		no flags
DetailsFormatted DiffDiff
Correct box-shadow behavior when using blur and border-radius. (52.70 KB, patch)
2010-11-04 22:35 PDT, Helder Correia 		ariya.hidayat: review-
DetailsFormatted DiffDiff
Correct basic-shadows line segments. (50.63 KB, patch)
2010-11-05 13:20 PDT, Helder Correia 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Ariya Hidayat
Comment 1 2010-10-25 00:50:02 PDT
Created attachment 71720 [details] Patch
Ariya Hidayat
Comment 2 2010-10-25 03:09:20 PDT
Comment on attachment 71720 [details] Patch Clearing flags on attachment: 71720 Committed r70447: <http://trac.webkit.org/changeset/70447>
Ariya Hidayat
Comment 3 2010-10-25 03:09:26 PDT
All reviewed patches have been landed. Closing bug.
Helder Correia
Comment 4 2010-11-04 22:35:28 PDT
Created attachment 73037 [details] Correct box-shadow behavior when using blur and border-radius. Updated blur rounded corner box shadow.
Ariya Hidayat
Comment 5 2010-11-05 09:08:12 PDT
Comment on attachment 73037 [details] Correct box-shadow behavior when using blur and border-radius. LGTM.
Ariya Hidayat
Comment 6 2010-11-05 12:34:55 PDT
Comment on attachment 73037 [details] Correct box-shadow behavior when using blur and border-radius. r- because it includes a fix which is not landed yet.
Helder Correia
Comment 7 2010-11-05 13:20:20 PDT
Created attachment 73106 [details] Correct basic-shadows line segments. Updated basic-shadows expected PNG
Ariya Hidayat
Comment 8 2010-11-05 18:40:20 PDT
Comment on attachment 73106 [details] Correct basic-shadows line segments. LGTM.
Ariya Hidayat
Comment 9 2010-11-06 09:47:47 PDT
reopening
Ariya Hidayat
Comment 10 2010-11-06 18:14:13 PDT
Comment on attachment 73106 [details] Correct basic-shadows line segments. Remove from cq, seems the bot can't handle it.
Eric Seidel (no email)
Comment 11 2010-11-06 21:02:44 PDT
I'm not sure what you mean by that? Do we need a bug against the cq?
Andreas Kling
Comment 12 2010-11-07 17:49:56 PST
Committed r71486: <http://trac.webkit.org/changeset/71486>
Ariya Hidayat
Comment 13 2010-11-07 17:53:01 PST
> I'm not sure what you mean by that? Do we need a bug against the cq? The bot was doing the right thing. It could not land the patch because the tree was red (for SL?).
Note You need to log in before you can comment on or make changes to this bug.