Bug 48184

Summary: build-webkit: reformat support variables for better maintainability
Product: WebKit Reporter: David Kilzer (:ddkilzer) <ddkilzer>
Component: Tools / TestsAssignee: David Kilzer (:ddkilzer) <ddkilzer>
Status: RESOLVED FIXED    
Severity: Normal CC: aroben, dbates, sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 48185    
Attachments:
Description Flags
Patch v1 dbates: review+

David Kilzer (:ddkilzer)
Reported 2010-10-23 06:29:39 PDT
build-webkit: reformat support variables for better maintainability
Attachments
Patch v1 (8.36 KB, patch)
2010-10-23 06:32 PDT, David Kilzer (:ddkilzer) 		dbates: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
David Kilzer (:ddkilzer)
Comment 1 2010-10-23 06:32:53 PDT
Created attachment 71638 [details] Patch v1
Daniel Bates
Comment 2 2010-10-23 22:08:37 PDT
Comment on attachment 71638 [details] Patch v1 Looks good to me. r=me
Daniel Bates
Comment 3 2010-10-23 22:11:56 PDT
Comment on attachment 71638 [details] Patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=71638&action=review > WebKitTools/Scripts/build-webkit:62 > + $threeDCanvasSupport, > + $threeDRenderingSupport, These are not in alphabetical order. I take it you were ordering these assuming "threeD" is interpreted as "3D"?
Daniel Bates
Comment 4 2010-10-23 22:15:08 PDT
Comment on attachment 71638 [details] Patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=71638&action=review > WebKitTools/Scripts/build-webkit:90 > + $svgSupport, This is also not in the correct place if we are alphabetically ordering this list.
David Kilzer (:ddkilzer)
Comment 5 2010-10-24 06:52:48 PDT
(In reply to comment #3) > > WebKitTools/Scripts/build-webkit:62 > > + $threeDCanvasSupport, > > + $threeDRenderingSupport, > > These are not in alphabetical order. I take it you were ordering these assuming "threeD" is interpreted as "3D"? (In reply to comment #4) > > WebKitTools/Scripts/build-webkit:90 > > + $svgSupport, > > This is also not in the correct place if we are alphabetically ordering this list. I reworded the ChangeLog. What I did was to alphabetize @features by the name of the feature, then declare the support variables in the same order. Because variables can't start with a number ("3d"), the $threeD* variables appear at the top of the list. Also because "Support" is added to the end of all the variable names, $svgSupport is technically out of alphabetical order in the list compared to the other variable names, but it matches the order in @features. Thanks!
David Kilzer (:ddkilzer)
Comment 6 2010-10-24 06:53:30 PDT
Committed r70412: <http://trac.webkit.org/changeset/70412>
Note You need to log in before you can comment on or make changes to this bug.