Bug 48150

Summary: [Mac] LayoutTests/fast/events/spatial-navigation/snav-single-select.html hangs
Product: WebKit Reporter: Chang Shu <cshu>
Component: DOMAssignee: Chang Shu <cshu>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, tonikitoo
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 46905    
Attachments:
Description Flags
fix patch none

Chang Shu
Reported 2010-10-22 13:21:17 PDT
The above test hangs on Mac. For some reason, a visible graphic popup shows up during the DRT testing and it waits for input.
Attachments
fix patch (4.77 KB, patch)
2010-11-09 08:38 PST, Chang Shu 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Chang Shu
Comment 1 2010-11-09 08:38:23 PST
Created attachment 73381 [details] fix patch Here is basically what I did in this patch: When ARROW_KEYS_POP_MENU is defined, which is the case on Mac, do up/down key pop menu only when spatial navigation is not enabled. And when spatial navigation is enabled, do the work flow as if ARROW_KEYS_POP_MENU is not defined so that selecting items is allowed.
WebKit Commit Bot
Comment 2 2010-11-17 08:48:38 PST
Comment on attachment 73381 [details] fix patch Clearing flags on attachment: 73381 Committed r72210: <http://trac.webkit.org/changeset/72210>
WebKit Commit Bot
Comment 3 2010-11-17 08:48:44 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.