Bug 47777

Summary:

FrameLoader doesn't need an explicit userGesture parameter

Product:

WebKit

Reporter:

Adam Barth <abarth>

Component:

New Bugs

Assignee:

Adam Barth <abarth>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, eric, jnd, pkasting

Priority:

Version:

528+ (Nightly build)

Hardware:

Other

OS:

OS X 10.5

Attachments:

Description	Flags
Patch	none

Adam Barth

Reported 2010-10-17 03:03:24 PDT

FrameLoader doesn't need an explicit userGesture parameter

Attachments
Patch (20.57 KB, patch) 2010-10-17 03:06 PDT, Adam Barth	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Adam Barth

Comment 1 2010-10-17 03:06:12 PDT

Dimitri Glazkov (Google)

Comment 2 2010-10-17 08:22:46 PDT

Comment on attachment 70970 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=70970&action=review > WebCore/loader/NavigationScheduler.cpp:@ > void NavigationScheduler::scheduleLocati Might as well remove the remaining places where wasUserGesture is passed in and yank that param out.

Dimitri Glazkov (Google)

Comment 3 2010-10-17 08:41:12 PDT

Comment on attachment 70970 [details] Patch I guess that could be done in follow-up patch.

WebKit Commit Bot

Comment 4 2010-10-17 09:03:03 PDT

Comment on attachment 70970 [details] Patch Clearing flags on attachment: 70970 Committed r69924: <http://trac.webkit.org/changeset/69924>

WebKit Commit Bot

Comment 5 2010-10-17 09:03:09 PDT

All reviewed patches have been landed. Closing bug.

Adam Barth

Comment 6 2010-10-17 11:10:02 PDT

(In reply to comment #2) > (From update of attachment 70970 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=70970&action=review > > > WebCore/loader/NavigationScheduler.cpp:@ > > void NavigationScheduler::scheduleLocati > > Might as well remove the remaining places where wasUserGesture is passed in and yank that param out. Yep.

Note You need to log in before you can comment on or make changes to this bug.