Bug 47409

Summary: SVG feImage needs absolute subregion for preserveAspectRatio
Product: WebKit Reporter: Dirk Schulze <krit>
Component: SVGAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: mdelaney7, zherczeg, zimmermann
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
URL: http://dev.w3.org/SVG/profiles/1.1F2/test/svg/filters-image-03-f.svg
Bug Depends on:    
Bug Blocks: 68469, 26389    
Attachments:
Description Flags
Patch zimmermann: review+

Dirk Schulze
Reported 2010-10-08 05:09:14 PDT
SVG feImage needs the subregion in absolute coordinates to determine the correct destination position and size. I have a fix for this.
Attachments
Patch (64.76 KB, patch)
2010-10-08 05:28 PDT, Dirk Schulze 		zimmermann: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dirk Schulze
Comment 1 2010-10-08 05:28:31 PDT
Created attachment 70228 [details] Patch
Nikolas Zimmermann
Comment 2 2010-10-08 06:04:05 PDT
Comment on attachment 70228 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=70228&action=review > WebCore/platform/graphics/filters/FilterEffect.h:46 > +enum FilterEffectType { > + unknownEffectType, > + feImage, > + feTile, > + sourceInput This is ugly and doesn't conform to the style guide (style bot doesn't check this). "Enum members should user InterCaps with an initial capital letter." Also these names are confusing. FilterEffectTypeUnknown, FilterEffectTypeImage, FilterEffectTypeTile, FilterEffectTypeSourceInput The rest looks good. Except the name for the test directory, I'd prefer LayoutTest/svg/W3C-SVG-1.1-SE/ (capital SE). Please fix before landing.
Dirk Schulze
Comment 3 2010-10-08 12:41:29 PDT
Committed r69416: <http://trac.webkit.org/changeset/69416>
Note You need to log in before you can comment on or make changes to this bug.