Bug 47205

Summary: [V8] Add FileReader to active DOM map
Product: WebKit Reporter: Jian Li <jianli>
Component: WebCore Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: ericu
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: All   
Attachments:
Description Flags
Proposed Patch japhet: review+, jianli: commit-queue-

Jian Li
Reported 2010-10-05 13:34:43 PDT
We need to add FileReader to active DOM map in V8 bindings such that it will not be GC-ed when it is still active. This is needed to fix the Chromium bug: http://code.google.com/p/chromium/issues/detail?id=56997
Attachments
Proposed Patch (5.13 KB, patch)
2010-10-05 13:46 PDT, Jian Li 		japhet: review+
jianli: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Jian Li
Comment 1 2010-10-05 13:46:19 PDT
Created attachment 69835 [details] Proposed Patch
Nate Chapin
Comment 2 2010-10-05 14:03:51 PDT
Comment on attachment 69835 [details] Proposed Patch Please also add this file to Android.v8bindings.mk and WebCore.pro before submitting.
Jian Li
Comment 3 2010-10-05 14:41:25 PDT
Commited as http://trac.webkit.org/changeset/69148. Add the new file to Android.v8bindings.mk. I do not add it to WebCore.pro since it seems not to be using V8 bindings.
Note You need to log in before you can comment on or make changes to this bug.