Bug 46595

Summary: Make pseudo-style resolution less hard-coded when used to select a shadow node
Product: WebKit Reporter: Dimitri Glazkov (Google) <dglazkov>
Component: CSSAssignee: Dimitri Glazkov (Google) <dglazkov>
Status: RESOLVED FIXED    
Severity: Enhancement CC: arv, bdakin, eric, hyatt, simon.fraser
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on: 50790, 52917    
Bug Blocks: 44907, 46590, 48980    
Attachments:
Description Flags
WIP: Almost ready
none
WIP: Serialization almost works.
none
Ready for review
none
Corrected the issue with multiple specifiers.
none
Patch hyatt: review+

Dimitri Glazkov (Google)
Reported 2010-09-26 16:55:45 PDT
in effect, implement plumbing for pseudo attribute from: http://dev.w3.org/2006/xbl2/Overview.html#the-pseudo-attribute
Attachments
WIP: Almost ready (17.02 KB, patch)
2011-01-05 16:54 PST, Dimitri Glazkov (Google) 		no flags
DetailsFormatted DiffDiff
WIP: Serialization almost works. (17.59 KB, patch)
2011-01-06 09:38 PST, Dimitri Glazkov (Google) 		no flags
DetailsFormatted DiffDiff
Ready for review (23.35 KB, patch)
2011-01-07 13:18 PST, Dimitri Glazkov (Google) 		no flags
DetailsFormatted DiffDiff
Corrected the issue with multiple specifiers. (23.29 KB, patch)
2011-01-07 14:50 PST, Dimitri Glazkov (Google) 		no flags
DetailsFormatted DiffDiff
Patch (31.11 KB, patch)
2011-01-08 20:05 PST, Dimitri Glazkov (Google) 		hyatt: review+
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Dimitri Glazkov (Google)
Comment 1 2010-12-17 08:49:06 PST
See https://bugs.webkit.org/show_bug.cgi?id=50790#c3 for specific steps on how to do this.
Dimitri Glazkov (Google)
Comment 2 2011-01-05 16:54:07 PST
Created attachment 78063 [details] WIP: Almost ready
Dimitri Glazkov (Google)
Comment 3 2011-01-05 16:55:50 PST
(In reply to comment #2) > Created an attachment (id=78063) [details] > WIP: Almost ready I am not sure I need both CSSSelector::PseudoShadowElement and CSSSelector::ShadowHost, but it does make the logic easier to understand. WDYT?
Dimitri Glazkov (Google)
Comment 4 2011-01-06 08:57:20 PST
Still to do: 1) We're supposed to throw SYNTAX_ERR on unknown pseudo elements. How are we going to handle this now? 2) Unscrew-up pseudo element selector serialization.
Dimitri Glazkov (Google)
Comment 5 2011-01-06 09:38:27 PST
Created attachment 78126 [details] WIP: Serialization almost works.
Dimitri Glazkov (Google)
Comment 6 2011-01-07 13:18:44 PST
Created attachment 78262 [details] Ready for review
Dimitri Glazkov (Google)
Comment 7 2011-01-07 14:50:56 PST
Created attachment 78274 [details] Corrected the issue with multiple specifiers.
Dimitri Glazkov (Google)
Comment 8 2011-01-08 11:04:05 PST
Comment on attachment 78274 [details] Corrected the issue with multiple specifiers. I wrote a comprehensive test for selectors to double-check that I didn't screw anything up, and it turns out I did! :) New patch coming up.
Dimitri Glazkov (Google)
Comment 9 2011-01-08 20:05:03 PST
Created attachment 78338 [details] Patch
Dimitri Glazkov (Google)
Comment 10 2011-01-08 20:06:11 PST
(In reply to comment #9) > Created an attachment (id=78338) [details] > Patch Now with tests! I can't believe we didn't good have coverage for namespaces/elements/specifier_lists combinations.
Dave Hyatt
Comment 11 2011-01-11 12:53:29 PST
Comment on attachment 78338 [details] Patch r=me. Looks good.
Dimitri Glazkov (Google)
Comment 12 2011-01-11 13:05:44 PST
Committed r75543: <http://trac.webkit.org/changeset/75543>
Note You need to log in before you can comment on or make changes to this bug.