Bug 46191

Summary: Make collapsed borders in tables work with different block flows
Product: WebKit Reporter: Dave Hyatt <hyatt>
Component: Layout and RenderingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: mitz
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 46417    
Attachments:
Description Flags
Patch hyatt: review+

Dave Hyatt
Reported 2010-09-21 09:13:42 PDT
The borderStart/End/Before/After methods are hardcoded to a specific block flow directionality for collapsed border tables.
Attachments
Patch (43.56 KB, patch)
2010-11-03 10:24 PDT, mitz 		hyatt: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
mitz
Comment 1 2010-11-03 10:24:22 PDT
Created attachment 72838 [details] Patch
Dave Hyatt
Comment 2 2010-11-03 10:58:19 PDT
Comment on attachment 72838 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=72838&action=review r=me > WebCore/rendering/RenderTableCell.cpp:666 > +CollapsedBorderValue RenderTableCell::collapsedLeftBorder() const > +{ > + if (table()->style()->isHorizontalWritingMode()) > + return table()->style()->isLeftToRightDirection() ? collapsedStartBorder() : collapsedEndBorder(); > + return table()->style()->isFlippedBlocksWritingMode() ? collapsedAfterBorder() : collapsedBeforeBorder(); I would cache table()->style() in a local and then use it in the three places where you acccess it. Ditto for collapsedRight/Top/BottomBorder. > WebCore/rendering/RenderTableCell.cpp:743 > +int RenderTableCell::borderHalfRight(bool outer) const > +{ > + if (table()->style()->isHorizontalWritingMode()) > + return table()->style()->isLeftToRightDirection() ? borderHalfEnd(outer) : borderHalfStart(outer); > + return table()->style()->isFlippedBlocksWritingMode() ? borderHalfBefore(outer) : borderHalfAfter(outer); Same comment. Cache table()->style() in a local. Same for all of the borderHalf*** functions.
mitz
Comment 3 2010-11-03 11:04:38 PDT
Landed as <http://trac.webkit.org/projects/webkit/changeset/71251>.
Note You need to log in before you can comment on or make changes to this bug.