Bug 45517

Summary: [DRT/Chromium] Remove dependency to base/string16.h and gfx/codec/png_codec.h
Product: WebKit Reporter: Kent Tamura <tkent>
Component: Tools / TestsAssignee: Kent Tamura <tkent>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov, tony, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 36641    
Attachments:
Description Flags
Patch none

Kent Tamura
Reported 2010-09-09 20:01:44 PDT
[DRT/Chromium] Remove dependency to base/string16.h and gfx/codec/png_codec.h
Attachments
Patch (6.17 KB, patch)
2010-09-09 20:06 PDT, Kent Tamura 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kent Tamura
Comment 1 2010-09-09 20:06:14 PDT
Created attachment 67146 [details] Patch
WebKit Review Bot
Comment 2 2010-09-09 20:09:10 PDT
Attachment 67146 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1 WebKitTools/DumpRenderTree/chromium/ImageDiff.cpp:39: Found other header before a header this file implements. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] Total errors found: 1 in 6 files If any of these errors are false positives, please file a bug against check-webkit-style.
Tony Chang
Comment 3 2010-09-10 09:49:55 PDT
Comment on attachment 67146 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=67146&action=prettypatch > WebKitTools/DumpRenderTree/chromium/ImageDiff.cpp:40 > +#include "webkit/support/webkit_support_gfx.h" > #include <algorithm> Is the style checker just complaining about not including ImageDiff.h? Seems fine to ignore.
Kent Tamura
Comment 4 2010-09-12 21:20:22 PDT
(In reply to comment #3) > > WebKitTools/DumpRenderTree/chromium/ImageDiff.cpp:40 > > +#include "webkit/support/webkit_support_gfx.h" > > #include <algorithm> > Is the style checker just complaining about not including ImageDiff.h? Seems fine to ignore. Yes. It's ignorable.
Kent Tamura
Comment 5 2010-09-12 21:21:35 PDT
Comment on attachment 67146 [details] Patch Clearing flags on attachment: 67146 Committed r67363: <http://trac.webkit.org/changeset/67363>
Kent Tamura
Comment 6 2010-09-12 21:21:43 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.