Bug 45001

Summary: [Qt] tst_QWebPage::originatingObjectInNetworkRequests() fails on trunk
Product: WebKit Reporter: Benjamin Poulain <benjamin>
Component: Tools / TestsAssignee: Benjamin Poulain <benjamin>
Status: RESOLVED FIXED    
Severity: Normal CC: ademar, commit-queue
Priority: P2 Keywords: Qt, QtTriaged
Version: 528+ (Nightly build)   
Hardware: PC   
OS: All   
Bug Depends on:    
Bug Blocks: 44675    
Attachments:
Description Flags
Patch none

Benjamin Poulain
Reported 2010-08-31 16:07:51 PDT
The auto test tst_QWebPage::originatingObjectInNetworkRequests() fails with the new parser. The test is actually broken due to a bad copy paste ("data:text/html,") so that is an oportunity to fix it.
Attachments
Patch (1.54 KB, patch)
2010-08-31 16:11 PDT, Benjamin Poulain 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Benjamin Poulain
Comment 1 2010-08-31 16:11:23 PDT
Created attachment 66131 [details] Patch Fix the test, we should not use data encoded URL since we are not setting an URL but setting the substituteData directly.
WebKit Commit Bot
Comment 2 2010-08-31 18:56:05 PDT
Comment on attachment 66131 [details] Patch Clearing flags on attachment: 66131 Committed r66565: <http://trac.webkit.org/changeset/66565>
WebKit Commit Bot
Comment 3 2010-08-31 18:56:09 PDT
All reviewed patches have been landed. Closing bug.
Ademar Reis
Comment 4 2010-09-01 14:45:04 PDT
Revision r66565 cherry-picked into qtwebkit-2.1 with commit c121913db5cec9acebf477036324051b8b1d3660
Note You need to log in before you can comment on or make changes to this bug.