Bug 44452

Summary: Add SynchronousLoader for ResourceHandleWin
Product: WebKit Reporter: Patrick R. Gansterer <paroga>
Component: PlatformAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: aroben, commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Windows XP   
Bug Depends on:    
Bug Blocks: 43712    
Attachments:
Description Flags
Patch
aroben: review+
Patch
aroben: review+, aroben: commit-queue+
Patch none

Patrick R. Gansterer
Reported 2010-08-23 13:03:34 PDT
see patch
Attachments
Patch (3.26 KB, patch)
2010-08-23 13:09 PDT, Patrick R. Gansterer 		aroben: review+
DetailsFormatted DiffDiff
Patch (3.26 KB, patch)
2010-08-24 06:45 PDT, Patrick R. Gansterer 		aroben: review+
aroben: commit-queue+
DetailsFormatted DiffDiff
Patch (3.26 KB, patch)
2010-08-24 07:11 PDT, Patrick R. Gansterer 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Patrick R. Gansterer
Comment 1 2010-08-23 13:09:31 PDT
Created attachment 65157 [details] Patch userAgent argument at WebCoreSynchronousLoader constructor will be used in a further patch
Adam Roben (:aroben)
Comment 2 2010-08-24 06:41:16 PDT
Comment on attachment 65157 [details] Patch > + WebCoreSynchronousLoader(ResourceError&, ResourceResponse &, Vector<char>&, const String& userAgent); Extra space before & here. r=me
Patrick R. Gansterer
Comment 3 2010-08-24 06:45:09 PDT
Created attachment 65268 [details] Patch (In reply to comment #2) > (From update of attachment 65157 [details]) > > + WebCoreSynchronousLoader(ResourceError&, ResourceResponse &, Vector<char>&, const String& userAgent); > > Extra space before & here. Bug for stylecheker?
Adam Roben (:aroben)
Comment 4 2010-08-24 06:54:38 PDT
(In reply to comment #3) > (In reply to comment #2) > > (From update of attachment 65157 [details] [details]) > > > + WebCoreSynchronousLoader(ResourceError&, ResourceResponse &, Vector<char>&, const String& userAgent); > > > > Extra space before & here. > Bug for stylecheker? Filing a bug would be great!
Adam Roben (:aroben)
Comment 5 2010-08-24 06:56:27 PDT
Comment on attachment 65268 [details] Patch r=me
Patrick R. Gansterer
Comment 6 2010-08-24 07:11:11 PDT
Created attachment 65271 [details] Patch Once again, sorry for the typo.
WebKit Commit Bot
Comment 7 2010-08-24 17:39:26 PDT
Comment on attachment 65271 [details] Patch Clearing flags on attachment: 65271 Committed r65957: <http://trac.webkit.org/changeset/65957>
WebKit Commit Bot
Comment 8 2010-08-24 17:39:31 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.