Bug 43978

Summary: [CMake] Set target properties only if available
Product: WebKit Reporter: Patrick R. Gansterer <paroga>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, leandro, zimmermann
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 43906    
Attachments:
Description Flags
Patch none

Patrick R. Gansterer
Reported 2010-08-13 08:55:51 PDT
CMake throws an error if you call e.g. ADD_TARGET_PROPERTIES with an empty argument.
Attachments
Patch (5.58 KB, patch)
2010-08-13 09:22 PDT, Patrick R. Gansterer 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Patrick R. Gansterer
Comment 1 2010-08-13 09:22:30 PDT
Created attachment 64351 [details] Patch
Leandro Pereira
Comment 2 2010-08-13 10:15:00 PDT
I'm not a reviewer, but the patch looks fine to me.
WebKit Commit Bot
Comment 3 2010-08-14 08:18:18 PDT
Comment on attachment 64351 [details] Patch Clearing flags on attachment: 64351 Committed r65366: <http://trac.webkit.org/changeset/65366>
WebKit Commit Bot
Comment 4 2010-08-14 08:18:23 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.