Bug 43533
| Summary: | When DEVICE_ORIENTATION is enabled, m_client always ASSERTS | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Dean Jackson <dino> |
| Component: | DOM | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED WONTFIX | ||
| Severity: | Normal | CC: | dino, steveblock |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | All | ||
| OS: | All | ||
Dean Jackson
If you simply build with DEVICE_ORIENTATION enabled,
DeviceOrientationController::DeviceOrientationController(WebCore::Page*, WebCore::DeviceOrientationClient*))
will always assert because there is no client created in the default build.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Steve Block
This is working as intended. DeviceOrientation, like most features, requires that a non-null client is supplied. Platforms need to make sure that they supply non-null clients for all such features they choose to enable. See the comment for the PageClients structure in Page.h.