Bug 43073

Summary: Pick up spec change w.r.t. replacement character and <frameset>
Product: WebKit Reporter: Adam Barth <abarth>
Component: New BugsAssignee: Adam Barth <abarth>
Status: RESOLVED FIXED    
Severity: Normal CC: eric
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 41123    
Attachments:
Description Flags
Patch
none
Patch none

Adam Barth
Reported 2010-07-27 13:29:28 PDT
Pick up spec change w.r.t. replacement character and <frameset>
Attachments
Patch (4.78 KB, patch)
2010-07-27 13:30 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
Patch (5.34 KB, patch)
2010-08-04 17:23 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2010-07-27 13:30:47 PDT
Created attachment 62736 [details] Patch
Eric Seidel (no email)
Comment 2 2010-07-27 13:36:23 PDT
Comment on attachment 62736 [details] Patch WebCore/html/HTMLTreeBuilder.cpp:76 + inline bool hasSpecialCharacter(const String& string) hasNonSpecialCharacter? Your names are confusing here.
Adam Barth
Comment 3 2010-07-27 13:44:55 PDT
Comment on attachment 62736 [details] Patch Yeah, sorry, I dropped the not in the name by accident.
Adam Barth
Comment 4 2010-08-04 17:23:18 PDT
Created attachment 63517 [details] Patch
Eric Seidel (no email)
Comment 5 2010-08-04 17:31:04 PDT
Comment on attachment 63517 [details] Patch OK.
Adam Barth
Comment 6 2010-08-04 17:34:51 PDT
Comment on attachment 63517 [details] Patch Clearing flags on attachment: 63517 Committed r64698: <http://trac.webkit.org/changeset/64698>
Adam Barth
Comment 7 2010-08-04 17:34:58 PDT
All reviewed patches have been landed. Closing bug.
Alexey Proskuryakov
Comment 8 2010-08-05 00:02:00 PDT
+ Pick up spec change w.r.t. replacement character and <frameset> + https://bugs.webkit.org/show_bug.cgi?id=43073 I would really appreciate a more detailed ChangeLog - there is no easy way to find out what changed here!
Adam Barth
Comment 9 2010-08-05 00:04:39 PDT
There was a discussion in the HTML WG and they decided to allow the <frameset> element to appear after replacement characters for compatibility with some home routers. They behavior change is documented in the tests. The "why" is because the WG said so. There's not much else to say, IMHO.
Note You need to log in before you can comment on or make changes to this bug.