Bug 42776

Summary: Pull HTML5lib test suite from upstream
Product: WebKit Reporter: Adam Barth <abarth>
Component: New BugsAssignee: Adam Barth <abarth>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, adele, commit-queue, dglazkov, eric, jamesr, mrobinson, webkit.review.bot, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 41123    
Attachments:
Description Flags
Patch none

Adam Barth
Reported 2010-07-21 12:44:06 PDT
Pull HTML5lib test suite from upstream
Attachments
Patch (120.61 KB, patch)
2010-07-21 12:45 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2010-07-21 12:45:43 PDT
Created attachment 62221 [details] Patch
Eric Seidel (no email)
Comment 2 2010-07-21 12:51:38 PDT
Comment on attachment 62221 [details] Patch rs=me. We should hash out with James if these are all correct or not. Regardless our test set should agree 100% with his. Did you do this manually? Or can we build a scriopt to show us the diff?
Adam Barth
Comment 3 2010-07-21 12:54:17 PDT
I did it manually, but it would be easy to write a script.
WebKit Commit Bot
Comment 4 2010-07-21 14:41:48 PDT
Comment on attachment 62221 [details] Patch Clearing flags on attachment: 62221 Committed r63858: <http://trac.webkit.org/changeset/63858>
WebKit Commit Bot
Comment 5 2010-07-21 14:41:54 PDT
All reviewed patches have been landed. Closing bug.
WebKit Review Bot
Comment 6 2010-07-21 15:01:18 PDT
http://trac.webkit.org/changeset/63858 might have broken GTK Linux 32-bit Release and Qt Linux Release
Eric Seidel (no email)
Comment 7 2010-07-21 15:49:01 PDT
It looks like our <keygen> support is platform specific? That seems strange. Gtk is failing to generate the same <keygen> DOM as the other ports.
Eric Seidel (no email)
Comment 8 2010-07-21 15:49:52 PDT
I should note, the correct fix is NOT to skip this test on Gtk. But we could remove this keygen part of the test suite. If we do that, we may need to regen both HTML5 and non-html test results for runner.html.
Adam Barth
Comment 9 2010-07-21 15:52:27 PDT
I already skipped the test before reading your message. I don't see another feasible solution in the short term.
Eric Seidel (no email)
Comment 10 2010-07-21 15:59:09 PDT
This is the code causing the failures: http://trac.webkit.org/browser/trunk/WebCore/html/HTMLKeygenElement.cpp#L43 Due to Qt/Gtk lacking support: http://trac.webkit.org/browser/trunk/WebCore/platform/qt/TemporaryLinkStubsQt.cpp#L94 http://trac.webkit.org/browser/trunk/WebCore/platform/gtk/TemporaryLinkStubs.cpp#L46 The fix would be to make the <keygen> kids a shadow DOM or similar.
Eric Seidel (no email)
Comment 11 2010-07-21 16:13:36 PDT
I think I will need to talk to a rendering expert more to better understand what needs to be done here to make these Shadow Nodes. I suspect that either RenderMenuList will need to learn how to have shadow kids, or we'll need a custom renderer for HTMLKeygenElement?
Eric Seidel (no email)
Comment 12 2010-07-21 16:14:50 PDT
Looks like it already has a shadow dom: void RenderMenuList::createInnerBlock()
Note You need to log in before you can comment on or make changes to this bug.