Bug 42541

Summary: WebKitTestRunner needs layoutTestController.pathToLocalResource
Product: WebKit Reporter: Maciej Stachowiak <mjs>
Component: WebKit2Assignee: Chang Shu <cshu>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, commit-queue, cshu, eric, sam
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Bug Depends on: 58665    
Bug Blocks: 58826, 197965    
Attachments:
Description Flags
fix patch none

Maciej Stachowiak
Reported 2010-07-18 21:44:05 PDT
WebKitTestRunner needs layoutTestController.pathToLocalResource
Attachments
fix patch (8.59 KB, patch)
2011-04-18 07:37 PDT, Chang Shu 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Maciej Stachowiak
Comment 1 2010-07-18 21:51:39 PDT
<rdar://problem/8204912>
Chang Shu
Comment 2 2011-04-15 08:45:54 PDT
quite some tests still fail due to console message issue in 58665 even the pathToLocalResource method is fixed.
Chang Shu
Comment 3 2011-04-18 07:37:53 PDT
Created attachment 90032 [details] fix patch
Eric Seidel (no email)
Comment 4 2011-04-18 09:06:05 PDT
Comment on attachment 90032 [details] fix patch View in context: https://bugs.webkit.org/attachment.cgi?id=90032&action=review OK. > Tools/WebKitTestRunner/InjectedBundle/mac/LayoutTestControllerMac.mm:61 > + return JSStringRetain(url); // Do nothing on mac. That's because mac doesn't disable access to file: urls? > Tools/WebKitTestRunner/InjectedBundle/win/LayoutTestControllerWin.cpp:64 > + return JSStringRetain(url); // TODO. I think we normally use FIXME.
Chang Shu
Comment 5 2011-04-18 09:15:19 PDT
Thanks for the quick review. > > Tools/WebKitTestRunner/InjectedBundle/mac/LayoutTestControllerMac.mm:61 > > + return JSStringRetain(url); // Do nothing on mac. > > That's because mac doesn't disable access to file: urls? This is what DRT does. I guess there's no need to do any transform to native platform on Mac. > > > Tools/WebKitTestRunner/InjectedBundle/win/LayoutTestControllerWin.cpp:64 > > + return JSStringRetain(url); // TODO. > > I think we normally use FIXME. Sure. Will fix.
Chang Shu
Comment 6 2011-04-18 09:22:54 PDT
I didn't know it's already cq+. will keep in mind. > Sure. Will fix.
WebKit Commit Bot
Comment 7 2011-04-18 10:41:19 PDT
Comment on attachment 90032 [details] fix patch Clearing flags on attachment: 90032 Committed r84160: <http://trac.webkit.org/changeset/84160>
WebKit Commit Bot
Comment 8 2011-04-18 10:41:23 PDT
All reviewed patches have been landed. Closing bug.
WebKit Commit Bot
Comment 9 2011-04-18 10:53:16 PDT
The commit-queue encountered the following flaky tests while processing attachment 90032 [details]: java/lc3/JSObject/ToObject-001.html bug 53091 (author: ap@webkit.org) http/tests/xmlhttprequest/re-login.html bug 51987 (author: ap@webkit.org) The commit-queue is continuing to process your patch.
Brent Fulgham
Comment 10 2022-02-10 21:32:33 PST
*** Bug 42678 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.