Bug 42435
| Summary: | Enable Web Timing for Win port | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Tony Gentilcore <tonyg> |
| Component: | WebKit Misc. | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED CONFIGURATION CHANGED | ||
| Severity: | Normal | CC: | bfulgham, joepeck |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | PC | ||
| OS: | OS X 10.5 | ||
| Bug Depends on: | 42772 | ||
| Bug Blocks: | 30685 | ||
Tony Gentilcore
Web Timing should be enabled for the Qt port.
This involves the following:
1. Implement http://trac.webkit.org/browser/trunk/WebCore/platform/network/ResourceLoadTiming.h
2. Flip WEB_TIMING flag
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Joseph Pecoraro
It looks like all ports, including Windows, enable WEB_TIMING. Lets close.
Tools/Scripts/webkitperl/FeatureList.pm
408: define => "ENABLE_WEB_TIMING", default => 1, value => \$webTimingSupport },
Tools/TestWebKitAPI/Configurations/FeatureDefines.xcconfig
199:ENABLE_WEB_TIMING = ENABLE_WEB_TIMING;
Source/cmake/OptionsEfl.cmake
133:WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_WEB_TIMING PUBLIC ON)
Source/cmake/OptionsWin.cmake
61:WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_WEB_TIMING PUBLIC ON)
Source/cmake/WebKitFeatures.cmake
193: WEBKIT_OPTION_DEFINE(ENABLE_WEB_TIMING "Toggle Web Timing support" PRIVATE ON)
Source/cmake/tools/vsprops/FeatureDefines.props
77: <ENABLE_WEB_TIMING>ENABLE_WEB_TIMING</ENABLE_WEB_TIMING>
Source/cmake/tools/vsprops/FeatureDefinesCairo.props
76: <ENABLE_WEB_TIMING>ENABLE_WEB_TIMING</ENABLE_WEB_TIMING>