Bug 42404

Summary: deleteCol{1,2,3} and insertCols{1,2,3} will fail in HTML5 parser
Product: WebKit Reporter: Adam Barth <abarth>
Component: New BugsAssignee: Adam Barth <abarth>
Status: RESOLVED FIXED    
Severity: Normal CC: eric, hyatt, ian
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 41123, 42346    
Attachments:
Description Flags
Patch eric: review+, eric: commit-queue-

Adam Barth
Reported 2010-07-15 14:01:29 PDT
deleteCol{1,2,3} and insertCols{1,2,3} will fail in HTML5 parser
Attachments
Patch (4.66 KB, patch)
2010-07-15 14:06 PDT, Adam Barth 		eric: review+
eric: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2010-07-15 14:06:51 PDT
Created attachment 61716 [details] Patch
Eric Seidel (no email)
Comment 2 2010-07-15 14:13:49 PDT
What does IE do? It may be expected that table.removeChild(col) works even if col is not a direct child of table. I feel like I've seen similar hacks like that in the DOM for table support.
Adam Barth
Comment 3 2010-07-15 14:17:06 PDT
The tests fail in IE8 as currently written. Let me try the new versions.
Adam Barth
Comment 4 2010-07-15 14:19:31 PDT
The new tests seem to fail in IE8 also for layout reasons. However, the DOM operations appear to work as expected.
Adam Barth
Comment 5 2010-07-15 14:20:11 PDT
Bottom line: this colgroup business appears to make us more IE-like.
Eric Seidel (no email)
Comment 6 2010-07-15 14:23:56 PDT
so IE adds implicit colgroup elements, but table.removeChild(col) still works? Does table.removeChild(col) remove the colgroup too?
Adam Barth
Comment 7 2010-07-15 14:27:01 PDT
(In reply to comment #6) > so IE adds implicit colgroup elements, but table.removeChild(col) still works? No. The test as written fails in IE the same way it will fail with the HTML5 parser. > Does table.removeChild(col) remove the colgroup too? No. It throws an illegal instruction exception, similar to exception we'll throw.
Eric Seidel (no email)
Comment 8 2010-07-15 14:29:24 PDT
Comment on attachment 61716 [details] Patch Please update the ChangeLog to explain that you tested in IE8, etc. and explain IE's exact behavior. I think it's important for us to justify this change for future readers of these tests. I wonder if old FF added implicit colgroup elements or not. Thank you for looking at this.
Adam Barth
Comment 9 2010-07-15 14:39:38 PDT
Committed r63464: <http://trac.webkit.org/changeset/63464>
Note You need to log in before you can comment on or make changes to this bug.