Bug 42364
| Summary: | [Qt] Improve test covrage for QScriptValue | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Jędrzej Nowacki <jedrzej.nowacki> |
| Component: | JavaScriptCore | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED INVALID | ||
| Severity: | Normal | CC: | jedrzej.nowacki |
| Priority: | P2 | Keywords: | Qt, QtTriaged |
| Version: | 528+ (Nightly build) | ||
| Hardware: | PC | ||
| OS: | All | ||
| Bug Depends on: | |||
| Bug Blocks: | 31863 | ||
Jędrzej Nowacki
QtScript have a great test covrage, but it could be even better.
Now the QScriptValue autotest use a set of values to check API, the set is initialized before each test case. Because of a lazy nature of a QScriptValue object, it is not perfect. The value after first contact with an engine get bound to it, so all other tests check modified version of the value. This was the main cause why bug 42363 was found in a benchmarks and not in an autotests.
I propose to recreate all values before each test.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |