Bug 42253

Summary: REGRESSION(r61484): Broke focus behaviour on Qt and probably other platforms
Product: WebKit Reporter: Kenneth Rohde Christiansen <kenneth>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Critical CC: commit-queue, darin, dglazkov, fishd, gustavo, hausmann, lucas.de.marchi, suzhe, tonikitoo, webkit-ews, webkit.review.bot, xan.lopez
Priority: P3 Keywords: Qt
Version: 528+ (Nightly build)   
Hardware: PC   
OS: All   
Bug Depends on:    
Bug Blocks: 35784    
Attachments:
Description Flags
A patch to fix this issue.
none
Fix two typos. none

Kenneth Rohde Christiansen
Reported 2010-07-14 06:01:30 PDT
r61484 changed the behaviour of setFocusedNode by calling setInputMethodState before the focused node is changed, something that Qt depended on and needs to depend on.
Attachments
A patch to fix this issue. (20.04 KB, patch)
2010-07-16 15:32 PDT, James Su 		no flags
DetailsFormatted DiffDiff
Fix two typos. (20.03 KB, patch)
2010-07-16 15:50 PDT, James Su 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Kenneth Rohde Christiansen
Comment 1 2010-07-14 06:06:36 PDT
Wouldn't it have been better if the patch had introduced a method to finish ongoing composition session? or make setInputMethodState take an enum instead?
Kenneth Rohde Christiansen
Comment 2 2010-07-14 06:07:17 PDT
EFL is affected as well according to demarchi.
Lucas De Marchi
Comment 3 2010-07-14 06:29:18 PDT
This is impacting the EFL implementation as well. In setInputMethodState we need the new focused node, not the old, in order to get the input method hints.
James Su
Comment 4 2010-07-14 09:49:08 PDT
(In reply to comment #1) > Wouldn't it have been better if the patch had introduced a method to finish ongoing composition session? or make setInputMethodState take an enum instead? Sounds better. Why way would you prefer? a new enum or an new method?
James Su
Comment 5 2010-07-16 15:32:58 PDT
Created attachment 61852 [details] A patch to fix this issue.
Early Warning System Bot
Comment 6 2010-07-16 15:38:31 PDT
Attachment 61852 [details] did not build on qt: Build output: http://webkit-commit-queue.appspot.com/results/3370531
WebKit Review Bot
Comment 7 2010-07-16 15:39:14 PDT
Attachment 61852 [details] did not build on gtk: Build output: http://webkit-commit-queue.appspot.com/results/3581076
WebKit Review Bot
Comment 8 2010-07-16 15:42:40 PDT
Attachment 61852 [details] did not build on chromium: Build output: http://webkit-commit-queue.appspot.com/results/3594045
James Su
Comment 9 2010-07-16 15:50:59 PDT
Created attachment 61854 [details] Fix two typos.
Darin Adler
Comment 10 2010-07-16 17:35:03 PDT
Can we make a regression test for this?
WebKit Commit Bot
Comment 11 2010-07-16 18:06:02 PDT
Comment on attachment 61854 [details] Fix two typos. Clearing flags on attachment: 61854 Committed r63602: <http://trac.webkit.org/changeset/63602>
WebKit Commit Bot
Comment 12 2010-07-16 18:06:08 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.