Bug 42096

Summary: HTMLTreeBuilder needs to support mixing SVG and MathML content
Product: WebKit Reporter: Eric Seidel (no email) <eric>
Component: New BugsAssignee: Eric Seidel (no email) <eric>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 41123    
Attachments:
Description Flags
Patch abarth: review+

Eric Seidel (no email)
Reported 2010-07-12 11:18:55 PDT
HTMLTreeBuilder needs to support mixing SVG and MathML content
Attachments
Patch (8.68 KB, patch)
2010-07-12 11:32 PDT, Eric Seidel (no email) 		abarth: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1 2010-07-12 11:32:15 PDT
Created attachment 61249 [details] Patch
Adam Barth
Comment 2 2010-07-12 13:31:48 PDT
Comment on attachment 61249 [details] Patch WebCore/html/HTMLTreeBuilder.cpp:1161 + return (token.name() != MathMLNames::mglyphTag Why ( .. ) ? We don't need those in C++. WebCore/html/HTMLTreeBuilder.cpp:1489 + // FIXME: We're missing a bunch of if branches here. I'd remove this comment.
Eric Seidel (no email)
Comment 3 2010-07-12 13:32:49 PDT
(In reply to comment #2) > (From update of attachment 61249 [details]) > WebCore/html/HTMLTreeBuilder.cpp:1161 > + return (token.name() != MathMLNames::mglyphTag > Why ( .. ) ? We don't need those in C++. Will remove. > WebCore/html/HTMLTreeBuilder.cpp:1489 > + // FIXME: We're missing a bunch of if branches here. > I'd remove this comment. That goes away two patches later. :)
Eric Seidel (no email)
Comment 4 2010-07-12 14:13:31 PDT
Committed r63116: <http://trac.webkit.org/changeset/63116>
Note You need to log in before you can comment on or make changes to this bug.