Bug 42018

Summary: Implement Web Timing redirectStart, redirectEnd, redirectCount
Product: WebKit Reporter: Tony Gentilcore <tonyg>
Component: WebCore Misc.Assignee: Tony Gentilcore <tonyg>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, commit-queue, dglazkov, eric, japhet, pfeldman, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on: 41816    
Bug Blocks: 30685    
Attachments:
Description Flags
Patch
none
Patch for landing
none
Patch for landing none

Attachments
Patch (19.25 KB, patch)
2010-07-11 16:52 PDT, Tony Gentilcore 		no flags
DetailsFormatted DiffDiff
Patch for landing (20.18 KB, patch)
2010-07-13 18:54 PDT, Tony Gentilcore 		no flags
DetailsFormatted DiffDiff
Patch for landing (21.21 KB, patch)
2010-07-14 08:40 PDT, Tony Gentilcore 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Tony Gentilcore
Comment 1 2010-07-11 16:52:36 PDT
Created attachment 61183 [details] Patch
Darin Fisher (:fishd, Google)
Comment 2 2010-07-12 22:22:08 PDT
Comment on attachment 61183 [details] Patch WebCore/loader/FrameLoaderTypes.h:64 + FrameLoadTimeline() i'm a little surprised to see this struct defined in this file. i always thought of this file as the place to put loader defined enums. normally, webkit has the style rule that you create a new file for each struct or class. WebCore/loader/MainResourceLoader.cpp:166 + frameLoadTimeline->redirectEnd = currentTime(); it might be good to call currentTime only once and then use that value for both redirectEnd and fetchStart. i think it is not wrong for them to be different, but it also seems ok (perhaps good) to say that they are exactly the same. R=me
Tony Gentilcore
Comment 3 2010-07-13 18:54:10 PDT
Created attachment 61454 [details] Patch for landing
Tony Gentilcore
Comment 4 2010-07-13 18:55:05 PDT
(In reply to comment #2) > (From update of attachment 61183 [details]) > WebCore/loader/FrameLoaderTypes.h:64 > + FrameLoadTimeline() > i'm a little surprised to see this struct defined in this file. > i always thought of this file as the place to put loader defined > enums. normally, webkit has the style rule that you create a > new file for each struct or class. > Noted. I added a FIXME to this patch and will move it out in a subsequent patch. > WebCore/loader/MainResourceLoader.cpp:166 > + frameLoadTimeline->redirectEnd = currentTime(); > it might be good to call currentTime only once and then use that value > for both redirectEnd and fetchStart. i think it is not wrong for them > to be different, but it also seems ok (perhaps good) to say that they > are exactly the same. Makes sense. Done. > > R=me
WebKit Commit Bot
Comment 5 2010-07-14 05:05:21 PDT
Comment on attachment 61454 [details] Patch for landing Rejecting patch 61454 from commit-queue. Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--exit-after-n-failures=1', '--ignore-tests', 'compositing', '--quiet']" exit_code: 1 Running build-dumprendertree Compiling Java tests make: Nothing to be done for `default'. Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests Testing 20685 test cases. fast/dom/Window/window-property-descriptors.html -> failed Exiting early after 1 failures. 6878 tests run. 120.45s total testing time 6877 test cases (99%) succeeded 1 test case (<1%) had incorrect layout Full output: http://webkit-commit-queue.appspot.com/results/3450296
Tony Gentilcore
Comment 6 2010-07-14 08:40:59 PDT
Created attachment 61527 [details] Patch for landing
WebKit Commit Bot
Comment 7 2010-07-14 09:46:06 PDT
Comment on attachment 61527 [details] Patch for landing Clearing flags on attachment: 61527 Committed r63326: <http://trac.webkit.org/changeset/63326>
WebKit Commit Bot
Comment 8 2010-07-14 09:46:12 PDT
All reviewed patches have been landed. Closing bug.
WebKit Review Bot
Comment 9 2010-07-14 10:10:50 PDT
http://trac.webkit.org/changeset/63326 might have broken Qt Linux Release
Note You need to log in before you can comment on or make changes to this bug.