Bug 41895

Summary: [MathML] Implement mathcolor and mathbackground attributes
Product: WebKit Reporter: François Sausset <sausset>
Component: MathMLAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Mac (Intel)   
OS: OS X 10.6   
Bug Depends on: 41889    
Bug Blocks: 3251    
Attachments:
Description Flags
Patch
none
Revised Patch none

François Sausset
Reported 2010-07-08 13:20:05 PDT
Implementation & test case for the mathcolor and mathbackground attributes defined in the MathML 3 w3c Draft: http://www.w3.org/TR/MathML3/chapter3.html#presm.presatt
Attachments
Patch (31.37 KB, patch)
2010-07-08 14:16 PDT, François Sausset 		no flags
DetailsFormatted DiffDiff
Revised Patch (31.36 KB, patch)
2010-07-08 14:46 PDT, François Sausset 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
François Sausset
Comment 1 2010-07-08 14:16:28 PDT
Created attachment 60957 [details] Patch
Kenneth Rohde Christiansen
Comment 2 2010-07-08 14:38:13 PDT
Comment on attachment 60957 [details] Patch WebCore/mathml/MathMLElement.cpp:4 + * Copyright (C) 2010 François Sausset (sausset@gmail.com). All rights reserved. There seems to be some unicode issues here. 62 if (attr->name() == MathMLNames::mathcolorAttr) { 63 addCSSProperty(attr, CSSPropertyColor, attr->value()); 64 } else if (attr->name() == MathMLNames::mathbackgroundAttr) { 65 addCSSProperty(attr, CSSPropertyBackgroundColor, attr->value()); 66 67 } else 68 StyledElement::parseMappedAttribute(attr); These one liners should not have braces. There is also a strange newline before the last else. Apart from this the patch looks fine. Please fix these things before committing.
François Sausset
Comment 3 2010-07-08 14:46:02 PDT
Created attachment 60962 [details] Revised Patch Correct the style issues.
Eric Seidel (no email)
Comment 4 2010-07-09 03:16:43 PDT
Comment on attachment 60957 [details] Patch Cleared Kenneth Rohde Christiansen's review+ from obsolete attachment 60957 [details] so that this bug does not appear in http://webkit.org/pending-commit.
WebKit Commit Bot
Comment 5 2010-07-09 11:23:13 PDT
Comment on attachment 60962 [details] Revised Patch Clearing flags on attachment: 60962 Committed r62968: <http://trac.webkit.org/changeset/62968>
WebKit Commit Bot
Comment 6 2010-07-09 11:23:17 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.