Bug 41839

Summary: [Qt] QScriptEngine should work correctly even after global object changes
Product: WebKit Reporter: Jędrzej Nowacki <jedrzej.nowacki>
Component: JavaScriptCoreAssignee: Jędrzej Nowacki <jedrzej.nowacki>
Status: RESOLVED FIXED    
Severity: Normal CC: cmarcelo, commit-queue, jedrzej.nowacki, kent.hansen
Priority: P2 Keywords: Qt, QtTriaged
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 31863    
Attachments:
Description Flags
Fix v1
none
Fix v1.01 none

Jędrzej Nowacki
Reported 2010-07-08 01:18:29 PDT
Some algorithms in the QScriptValue and in the QScriptEngine (like QSV::isError() method) are not prepared for Global Object changes. It would be nice to keep a reference to some of global object's properties in QScriptEnginePrivate, for future use.
Attachments
Fix v1 (22.74 KB, patch)
2010-07-14 04:42 PDT, Jędrzej Nowacki 		no flags
DetailsFormatted DiffDiff
Fix v1.01 (22.73 KB, patch)
2010-07-14 06:45 PDT, Jędrzej Nowacki 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Jędrzej Nowacki
Comment 1 2010-07-14 04:42:54 PDT
Created attachment 61502 [details] Fix v1
Jędrzej Nowacki
Comment 2 2010-07-14 06:45:38 PDT
Created attachment 61514 [details] Fix v1.01 Rebased against trunk
Kenneth Rohde Christiansen
Comment 3 2010-07-14 06:51:51 PDT
Comment on attachment 61514 [details] Fix v1.01 Nice that you are concentrating all method that will need C api in the future. r=me
WebKit Commit Bot
Comment 4 2010-07-14 07:35:18 PDT
Comment on attachment 61514 [details] Fix v1.01 Clearing flags on attachment: 61514 Committed r63318: <http://trac.webkit.org/changeset/63318>
WebKit Commit Bot
Comment 5 2010-07-14 07:35:22 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.