Bug 41623

Summary: Implement basic text node coalescing
Product: WebKit Reporter: Adam Barth <abarth>
Component: New BugsAssignee: Adam Barth <abarth>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, commit-queue, eric, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 41123    
Attachments:
Description Flags
Patch
none
Patch for landing none

Adam Barth
Reported 2010-07-05 10:01:38 PDT
Implement basic text node coalessing
Attachments
Patch (13.48 KB, patch)
2010-07-05 10:05 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
Patch for landing (14.35 KB, patch)
2010-07-05 21:11 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2010-07-05 10:05:46 PDT
Created attachment 60551 [details] Patch
Eric Seidel (no email)
Comment 2 2010-07-05 21:04:44 PDT
Comment on attachment 60551 [details] Patch WebCore/dom/CharacterData.cpp:62 + PassRefPtr<StringImpl> CharacterData::parserAppendData(const String& arg) We need a bunch more of these parser* functions. WebCore/dom/CharacterData.h:45 + // Similar to appendData, but optimized for the parser (e.g., no mutation I would have used "Like appendData" to keep it to one 80c line. :) WebCore/html/HTMLTreeBuilder.cpp:1583 + // was the last text node inserted by the parser. Can we write a test which fails this so we know when we fix it? Or do we know it's already covered?
Adam Barth
Comment 3 2010-07-05 21:11:23 PDT
Created attachment 60579 [details] Patch for landing
WebKit Commit Bot
Comment 4 2010-07-05 22:15:03 PDT
Comment on attachment 60579 [details] Patch for landing Clearing flags on attachment: 60579 Committed r62520: <http://trac.webkit.org/changeset/62520>
WebKit Commit Bot
Comment 5 2010-07-05 22:15:08 PDT
All reviewed patches have been landed. Closing bug.
WebKit Review Bot
Comment 6 2010-07-06 08:26:44 PDT
http://trac.webkit.org/changeset/62520 might have broken Leopard Intel Release (Tests)
Note You need to log in before you can comment on or make changes to this bug.