Bug 41366

Summary: [QT][S60] QGraphicsWebView based plugin crashes while destroying
Product: WebKit Reporter: Mahesh Kulkarni <maheshk>
Component: WebKit QtAssignee: Nobody <webkit-unassigned>
Status: RESOLVED DUPLICATE    
Severity: Normal CC: abhinav.mithal, cshu, kenneth, laszlo.gombos, yael
Priority: P2 Keywords: Qt
Version: 528+ (Nightly build)   
Hardware: S60 Hardware   
OS: S60 3rd edition   
Attachments:
Description Flags
proposed fix none

Mahesh Kulkarni
Reported 2010-06-29 11:57:06 PDT
Double deletion of PluginContainerSymbian causes crash while destroying the plugin on symbian phone. This is noticed only on QGraphicsWebView. Documentation from http://doc.trolltech.com/4.6.2/qgraphicsproxywidget.html "QGraphicsProxyWidget shares ownership with QWidget, so if either of the two widgets are destroyed, the other widget will be automatically destroyed as well."
Attachments
proposed fix (1.55 KB, patch)
2010-06-29 12:14 PDT, Mahesh Kulkarni 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Mahesh Kulkarni
Comment 1 2010-06-29 12:14:41 PDT
Created attachment 60042 [details] proposed fix No need to delete proxy separately as deleting any widget deletes both proxy and qwidget.
Yael
Comment 2 2010-06-29 12:53:34 PDT
This patch will cause all proxy widgets to be deleted only when the browser is exiting and I don't think it is desired behavior. Abhinav & I looked at this yesterday, and we thought that since the desctuctor of the QGraphicsProxyWidget deletes the container, we should not delete the container if there is a proxy widget. Abhinav is preparing a patch for that.
Mahesh Kulkarni
Comment 3 2010-06-30 21:34:21 PDT
Comment on attachment 60042 [details] proposed fix fix for this bug is checked in as part of https://bugs.webkit.org/show_bug.cgi?id=37303 Obsoleting the bug and closing the bug
Mahesh Kulkarni
Comment 4 2010-06-30 21:35:21 PDT
*** This bug has been marked as a duplicate of bug 37303 ***
Yael
Comment 5 2010-07-01 05:46:56 PDT
(In reply to comment #2) > This patch will cause all proxy widgets to be deleted only when the browser is exiting and I don't think it is desired behavior. > Abhinav & I looked at this yesterday, and we thought that since the desctuctor of the QGraphicsProxyWidget deletes the container, we should not delete the container if there is a proxy widget. > Abhinav is preparing a patch for that. Actually, the above comment is not true. Abhinav & I checked the code of QGraphicsProxyWidget and found that the proxy widget would have been deleted togather with the container. Sorry for the wrong comment :-)
Mahesh Kulkarni
Comment 6 2010-07-01 05:53:33 PDT
(In reply to comment #5) > (In reply to comment #2) > > This patch will cause all proxy widgets to be deleted only when the browser is exiting and I don't think it is desired behavior. > > Abhinav & I looked at this yesterday, and we thought that since the desctuctor of the QGraphicsProxyWidget deletes the container, we should not delete the container if there is a proxy widget. > > Abhinav is preparing a patch for that. > > Actually, the above comment is not true. Abhinav & I checked the code of QGraphicsProxyWidget and found that the proxy widget would have been deleted togather with the container. Sorry for the wrong comment :-) NP :) IMO either container or proxy deletion results in deletion of both by which we could avoid an extra check.
Note You need to log in before you can comment on or make changes to this bug.