Bug 41232

Summary: HTMLTreeBuilder should branch first on token type and then on insertion mode
Product: WebKit Reporter: Adam Barth <abarth>
Component: New BugsAssignee: Adam Barth <abarth>
Status: RESOLVED FIXED    
Severity: Normal CC: eric, mike
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 41123    
Attachments:
Description Flags
Patch none

Adam Barth
Reported 2010-06-25 15:56:45 PDT
HTMLTreeBuilder should branch first on token type and then on insertion mode
Attachments
Patch (23.44 KB, patch)
2010-06-25 15:59 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2010-06-25 15:59:17 PDT
Created attachment 59807 [details] Patch
Eric Seidel (no email)
Comment 2 2010-06-25 16:02:13 PDT
Comment on attachment 59807 [details] Patch What are the ASSERTS for? 483 switch (insertionMode()) { 484 case InitialMode: 485 ASSERT(insertionMode() == InitialMode)
Eric Seidel (no email)
Comment 3 2010-06-25 16:05:42 PDT
Comment on attachment 59807 [details] Patch I think this is going to end up much nicer, yes. Harder to compare the implementation to the spec though. We may need to keep some sort of document as to implementation status to help us make sure we cover all the spec.
Adam Barth
Comment 4 2010-06-25 16:36:48 PDT
Comment on attachment 59807 [details] Patch Clearing flags on attachment: 59807 Committed r61915: <http://trac.webkit.org/changeset/61915>
Adam Barth
Comment 5 2010-06-25 16:36:53 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.