Bug 41110

Summary: Move more form submission logic into FormSubmission.
Product: WebKit Reporter: Dimitri Glazkov (Google) <dglazkov>
Component: New BugsAssignee: Dimitri Glazkov (Google) <dglazkov>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, dglazkov, eric, tkent, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 39021    
Attachments:
Description Flags
Patch
none
Patch tkent: review+

Dimitri Glazkov (Google)
Reported 2010-06-23 16:21:39 PDT
Move more form submission logic into FormSubmission.
Attachments
Patch (31.87 KB, patch)
2010-06-23 16:32 PDT, Dimitri Glazkov (Google) 		no flags
DetailsFormatted DiffDiff
Patch (35.20 KB, patch)
2010-06-24 10:26 PDT, Dimitri Glazkov (Google) 		tkent: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Dimitri Glazkov (Google)
Comment 1 2010-06-23 16:32:12 PDT
Created attachment 59575 [details] Patch
Dimitri Glazkov (Google)
Comment 2 2010-06-23 16:34:23 PDT
Apologies for a largish patch -- I tried splitting it up, but the it was less readable in chunks.
Eric Seidel (no email)
Comment 3 2010-06-23 16:38:04 PDT
Attachment 59575 [details] did not build on mac: Build output: http://webkit-commit-queue.appspot.com/results/3331655
WebKit Review Bot
Comment 4 2010-06-23 19:01:14 PDT
Attachment 59575 [details] did not build on chromium: Build output: http://webkit-commit-queue.appspot.com/results/3313637
Dimitri Glazkov (Google)
Comment 5 2010-06-23 20:03:06 PDT
(In reply to comment #3) > Attachment 59575 [details] did not build on mac: > Build output: http://webkit-commit-queue.appspot.com/results/3331655 Weird... I don't get this error when building locally. I'll investigate.
Dimitri Glazkov (Google)
Comment 6 2010-06-24 10:26:42 PDT
Created attachment 59670 [details] Patch
Dimitri Glazkov (Google)
Comment 7 2010-06-24 10:28:26 PDT
(In reply to comment #6) > Created an attachment (id=59670) [details] > Patch I went back and forth on making FormSubmission::Attributes nested. It just looks prettier that way :)
Kent Tamura
Comment 8 2010-07-12 07:32:27 PDT
Comment on attachment 59670 [details] Patch WebCore/loader/FormSubmission.h:56 + { Indentation is wrong. It should be 8 spaces.
Dimitri Glazkov (Google)
Comment 9 2010-07-23 15:21:38 PDT
Fixed up and landed as http://trac.webkit.org/changeset/63999
Note You need to log in before you can comment on or make changes to this bug.