Bug 40650

Summary:

Enable HTML5 lexer

Product:

WebKit

Reporter:

Adam Barth <abarth>

Component:

New Bugs

Assignee:

Adam Barth <abarth>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, darin, eric, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Other

OS:

OS X 10.5

Bug Depends on:

Bug Blocks:

39259

Attachments:

Description	Flags
Patch	eric: review+, eric: commit-queue-

Adam Barth

Reported 2010-06-15 20:58:34 PDT

Enable HTML5 lexer

Attachments
Patch (51.79 KB, patch) 2010-06-15 21:53 PDT, Adam Barth	eric: review+ eric: commit-queue-	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Adam Barth

Comment 1 2010-06-15 21:53:51 PDT

Created attachment 58850 [details] Patch

Eric Seidel (no email)

Comment 2 2010-06-15 23:19:58 PDT

Comment on attachment 58850 [details] Patch LayoutTests/ChangeLog:61 + * inspector/timeline-script-tag-1-expected.txt: Our new behavior is fine. We just need to file a bug with the inspector to update their code a bit. LayoutTests/ChangeLog:60 + * inspector/audits-panel-functional-expected.txt: Did the explanation for this one go in the wrong place? Do we need a bug on this? LayoutTests/ChangeLog:44 + - I don't fully understand this behavior change. It might We should file a bug for this. LayoutTests/ChangeLog:101 + FFFD). Still investigating whether this is a real bug. We should probably turn all of these investigations into bugs at this point, since we're actually changing what everyone is using in their day-to-day builds. rs=me. I've seen all these changes for a while and they look expected. But we should be sure to send a note to webkit-dev pointing them to this change so they can comment about any of these behavioral changes. Thanks for putting this together.WebCore/page/Settings.cpp:135 + , m_html5ParserEnabled(true) Do we need to change WebKit as well? I think we might. Certainly we need to rename this setting at some point. If you file a bug on it or add it to the TODO list I can take care of it.

Eric Seidel (no email)

Comment 3 2010-06-15 23:21:07 PDT

We should consider closing the master bug after landing this too. :)

Adam Barth

Comment 4 2010-06-15 23:27:51 PDT

Committed r61234: <http://trac.webkit.org/changeset/61234>

WebKit Review Bot

Comment 5 2010-06-15 23:47:39 PDT

http://trac.webkit.org/changeset/61234 might have broken Qt Linux Release

Adam Barth

Comment 6 2010-06-15 23:49:17 PDT

Fixenating.