Bug 40572

Summary: [Qt] Stack overflow when converting navigator object to QVariant
Product: WebKit Reporter: Andreas Kling <kling>
Component: WebKit QtAssignee: QtWebKit Unassigned <webkit-qt-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, hausmann, ryukbk
Priority: P2 Keywords: Qt, QtTriaged
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 35784    
Attachments:
Description Flags
Proposed patch
none
Proposed patch v2 none

Andreas Kling
Reported 2010-06-14 08:01:01 PDT
The navigator object is infinitely recursive thanks to MimeType and Plugin. When converting it from a JSValue to a QVariant, we crash due to stack overflow.
Attachments
Proposed patch (9.24 KB, patch)
2010-06-14 08:02 PDT, Andreas Kling 		no flags
DetailsFormatted DiffDiff
Proposed patch v2 (9.17 KB, patch)
2010-06-14 08:14 PDT, Andreas Kling 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Andreas Kling
Comment 1 2010-06-14 08:02:16 PDT
Created attachment 58649 [details] Proposed patch
Andreas Kling
Comment 2 2010-06-14 08:14:42 PDT
Created attachment 58653 [details] Proposed patch v2 Lowered recursion limit to 200 (40000 was too big for default ulimit -s value on Linux.)
WebKit Commit Bot
Comment 3 2010-06-14 09:38:29 PDT
Comment on attachment 58653 [details] Proposed patch v2 Clearing flags on attachment: 58653 Committed r61127: <http://trac.webkit.org/changeset/61127>
WebKit Commit Bot
Comment 4 2010-06-14 09:38:34 PDT
All reviewed patches have been landed. Closing bug.
Andreas Kling
Comment 5 2010-07-08 12:15:09 PDT
*** Bug 41750 has been marked as a duplicate of this bug. ***
Simon Hausmann
Comment 6 2010-08-03 05:10:02 PDT
Revision r61127 cherry-picked into qtwebkit-2.0 with commit d6aa024c84f61d0602bef4eef84efaed7cfeefcc
Note You need to log in before you can comment on or make changes to this bug.