Bug 40458

Summary: HTML5Tokenizer should not delete itself while running scripts
Product: WebKit Reporter: Eric Seidel (no email) <eric>
Component: New BugsAssignee: Eric Seidel (no email) <eric>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, commit-queue, tonyg
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 39259    
Attachments:
Description Flags
Patch none

Eric Seidel (no email)
Reported 2010-06-10 19:00:19 PDT
HTML5Tokenizer should not delete itself while running scripts
Attachments
Patch (1.35 KB, patch)
2010-06-10 19:02 PDT, Eric Seidel (no email) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1 2010-06-10 19:02:02 PDT
Created attachment 58433 [details] Patch
Eric Seidel (no email)
Comment 2 2010-06-10 19:04:01 PDT
Comment on attachment 58433 [details] Patch Changes like this reenforce in my mind that we've chosen a sane architecture. :) It's not 100% clear to me why endIfDelayed does not allow ending in recursive write() calls, but attemptToEnd() does. That may be another bug. If these two checks match then we should abstract the if contents into a canEnd() helper.
Adam Barth
Comment 3 2010-06-10 21:37:34 PDT
Comment on attachment 58433 [details] Patch Nice.
WebKit Commit Bot
Comment 4 2010-06-11 08:28:59 PDT
Comment on attachment 58433 [details] Patch Clearing flags on attachment: 58433 Committed r61021: <http://trac.webkit.org/changeset/61021>
WebKit Commit Bot
Comment 5 2010-06-11 08:29:08 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.