Bug 40445

Summary: [Qt] Regression(r59956) - Return usable property names from DRT's computedStyleIncludingVisitedInfo()
Product: WebKit Reporter: Robert Hogan <robert>
Component: Tools / TestsAssignee: Robert Hogan <robert>
Status: RESOLVED FIXED    
Severity: Normal CC: hausmann, kenneth, tonikitoo
Priority: P2 Keywords: Qt, QtTriaged
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch kenneth: review+

Robert Hogan
Reported 2010-06-10 14:26:45 PDT
[Qt] Return usable property names from DRT's computedStyleIncludingVisitedInfo()
Attachments
Patch (3.76 KB, patch)
2010-06-10 14:31 PDT, Robert Hogan 		kenneth: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Robert Hogan
Comment 1 2010-06-10 14:31:30 PDT
Created attachment 58413 [details] Patch
Eric Seidel (no email)
Comment 2 2010-06-12 18:49:43 PDT
Comment on attachment 58413 [details] Patch Really!? Do other DRTs need to do this dance too? Seems sub-optimal if so.
Robert Hogan
Comment 3 2010-06-19 06:19:47 PDT
(In reply to comment #2) > (From update of attachment 58413 [details]) > Really!? Do other DRTs need to do this dance too? Seems sub-optimal if so. No, because they can access objects like JSContextRef and JSString directly. The Qt bridge converts JSCore objects to the appropriate Qt counterpart (e.g. QString) and QVariant if all else fails. These QVariant objects are basically large property maps - hence the need to translate the names containing hypens to JS variable-style names.
Kenneth Rohde Christiansen
Comment 4 2010-07-03 07:43:15 PDT
Comment on attachment 58413 [details] Patch Maybe our bridge should be doing this.
Antonio Gomes
Comment 5 2010-07-03 09:39:28 PDT
*** Bug 39597 has been marked as a duplicate of this bug. ***
Robert Hogan
Comment 6 2010-07-03 14:37:15 PDT
Committed r62450: <http://trac.webkit.org/changeset/62450>
Note You need to log in before you can comment on or make changes to this bug.