Bug 40412

Summary: [Qt] Explicit conversions to JSC opaque types should be removed.
Product: WebKit Reporter: Jędrzej Nowacki <jedrzej.nowacki>
Component: JavaScriptCoreAssignee: Jędrzej Nowacki <jedrzej.nowacki>
Status: RESOLVED FIXED    
Severity: Normal CC: hausmann, jedrzej.nowacki, kent.hansen
Priority: P2 Keywords: Qt, QtTriaged
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 31863, 40415    
Attachments:
Description Flags
Fix v1 hausmann: review+, hausmann: commit-queue-

Jędrzej Nowacki
Reported 2010-06-10 03:00:50 PDT
Conversion between JSC C types and QtScript private types, takes a main part of the source code. In most cases a mapping between the types is one to one. New cast operators should be introduced.
Attachments
Fix v1 (21.36 KB, patch)
2010-06-10 03:06 PDT, Jędrzej Nowacki 		hausmann: review+
hausmann: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Jędrzej Nowacki
Comment 1 2010-06-10 03:06:27 PDT
Created attachment 58351 [details] Fix v1 No new functionality, refactoring only.
Simon Hausmann
Comment 2 2010-06-11 03:28:46 PDT
Comment on attachment 58351 [details] Fix v1 r=me but the ChangeLog needs a little cleanup before landing. Right now it just starts with "Explicit conversions to JSC types were removed", which in the context of JavaScriptCore/ChangeLog does not make much sense. I'll change this when landing it. Perhaps we should use JavaScriptCore/qt/ChangeLog in the future.
Simon Hausmann
Comment 3 2010-06-11 03:36:44 PDT
Committed r61003: <http://trac.webkit.org/changeset/61003>
Note You need to log in before you can comment on or make changes to this bug.