Bug 40137

Created attachment 57811 [details] Patch

Created attachment 59218 [details] Patch

... and one more! Here I just basically plumb FormSubmission further in (not quite to the very end), and move some of the logic to more logical places :)

Comment on attachment 59218 [details] Patch > +#include "KURL.h" > #include "PlatformString.h" > #include <wtf/Forward.h> > #include <wtf/RefCounted.h> You probably don't need to include anything else if you include "KURL.h". I believe that includes all those other headers. > + void populateFrameLoadRequest(FrameLoadRequest&); This should be a const member function. > + void setReferrer(String referrer) { m_referrer = referrer; } > + void setOrigin(String origin) { m_origin = origin; } The arguments to these functions should be const String& rather than String. r=me

(In reply to comment #4) > (From update of attachment 59218 [details]) > > +#include "KURL.h" > > #include "PlatformString.h" > > #include <wtf/Forward.h> > > #include <wtf/RefCounted.h> > > You probably don't need to include anything else if you include "KURL.h". I believe that includes all those other headers. > > > + void populateFrameLoadRequest(FrameLoadRequest&); > > This should be a const member function. Not yet -- I still have to modify m_action there. But we're getting there :) > > > + void setReferrer(String referrer) { m_referrer = referrer; } > > > + void setOrigin(String origin) { m_origin = origin; } > > The arguments to these functions should be const String& rather than String. Done. > > r=me Landed as http://trac.webkit.org/changeset/61546.