Bug 40090

Summary: Set attributes.stencil to false by default at context creation
Product: WebKit Reporter: Zhenyao Mo <zmo>
Component: WebGLAssignee: Zhenyao Mo <zmo>
Status: RESOLVED FIXED    
Severity: Normal CC: cmarrin, commit-queue, kbr, oliver
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
patch none

Zhenyao Mo
Reported 2010-06-02 17:02:57 PDT
Seemed like on certain Mac with ATI cards, turning on stencil causes fps to drop tremendously. See https://bugs.webkit.org/show_bug.cgi?id=38560.
Attachments
patch (3.28 KB, patch)
2010-06-02 17:34 PDT, Zhenyao Mo 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kenneth Russell
Comment 1 2010-06-02 17:04:36 PDT
This requires a WebGL specification change, but one which has basically already been agreed upon by the WebGL working group.
Zhenyao Mo
Comment 2 2010-06-02 17:34:39 PDT
Created attachment 57718 [details] patch
Kenneth Russell
Comment 3 2010-06-02 17:55:16 PDT
(In reply to comment #2) > Created an attachment (id=57718) [details] > patch This looks okay, but it must not be committed until the associated changes have been made to the WebGL spec. I'll try to get this approved by the working group tomorrow morning. Are all of the other WebGL layout tests working with this change? In other words, there weren't any others dependent on the previous default of stencil=true?
Zhenyao Mo
Comment 4 2010-06-02 18:44:52 PDT
Yes, all the tests pass with this change.
David Levin
Comment 5 2010-06-02 19:56:05 PDT
Comment on attachment 57718 [details] patch Please set the r?/cq? when "the associated changes have been made to the WebGL spec" since "it must not be committed until" then. Until then it is just cluttering a really full review queue and nothing can be done for it.
Kenneth Russell
Comment 6 2010-06-03 12:21:55 PDT
The WebGL spec has been updated to indicate that the default value of the stencil flag is false. The patch looks good to me.
Dimitri Glazkov (Google)
Comment 7 2010-06-03 13:46:52 PDT
Comment on attachment 57718 [details] patch ok.
WebKit Commit Bot
Comment 8 2010-06-04 00:42:15 PDT
Comment on attachment 57718 [details] patch Clearing flags on attachment: 57718 Committed r60660: <http://trac.webkit.org/changeset/60660>
WebKit Commit Bot
Comment 9 2010-06-04 00:42:24 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.