Bug 39746

Summary:

[Qt] qt_runtime.h and .cpp have coding-style errors

Product:

WebKit

Reporter:

Anders Bakken <agbakken>

Component:

WebKit Qt

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED DUPLICATE

Severity:

Normal

CC:

ademar, benjamin, jesus, kenneth, kling, manish_c_mulimani, noam, peojala11

Priority:

Keywords:

Qt, QtTriaged

Version:

528+ (Nightly build)

Hardware:

OS:

All

Attachments:

Description	Flags
Patch that fixes the coding style issues	none
Patch that fixes the coding style issues	none

Anders Bakken

Reported 2010-05-26 09:32:44 PDT

WebCore/bridge/qt/qt_runtime.h:20: #ifndef header guard has wrong style, please use: qt_runtime_h [build/header_guard] [5] WebCore/bridge/qt/qt_runtime.h:76: This { should be at the end of the previous line [whitespace/braces] [4] WebCore/bridge/qt/qt_runtime.h:98: This { should be at the end of the previous line [whitespace/braces] [4] WebCore/bridge/qt/qt_runtime.h:170: This { should be at the end of the previous line [whitespace/braces] [4] WebCore/bridge/qt/qt_runtime.h:181: d_func is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] WebCore/bridge/qt/qt_runtime.h:193: This { should be at the end of the previous line [whitespace/braces] [4] WebCore/bridge/qt/qt_runtime.h:195: Extra space before ) [whitespace/parens] [2] WebCore/bridge/qt/qt_runtime.h:202: d_func is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] WebCore/bridge/qt/qt_runtime.h:213: This { should be at the end of the previous line [whitespace/braces] [4] Total errors found: 9 in 1 files

Attachments
Patch that fixes the coding style issues (4.13 KB, patch) 2010-05-26 09:57 PDT, Anders Bakken	no flags	Details Formatted Diff Diff
Patch that fixes the coding style issues (71.89 KB, patch) 2010-05-26 10:11 PDT, Anders Bakken	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Anders Bakken

Comment 1 2010-05-26 09:57:29 PDT

Created attachment 57108 [details] Patch that fixes the coding style issues

Anders Bakken

Comment 2 2010-05-26 10:09:49 PDT

*** Bug 39747 has been marked as a duplicate of this bug. ***

Anders Bakken

Comment 3 2010-05-26 10:11:46 PDT

Created attachment 57112 [details] Patch that fixes the coding style issues

Petri Ojala

Comment 4 2010-05-26 21:39:49 PDT

QtTriaged

Jesus Sanchez-Palencia

Comment 5 2010-06-29 10:15:46 PDT

Is this waiting for review? Maybe Anders forgot the flag...

Benjamin Poulain

Comment 6 2011-01-07 11:40:57 PST

Anders, what is the status of this?

manish_c_mulimani

Comment 7 2011-05-22 23:34:11 PDT

There is no activity on this bug from a long time. So can I assign it to myself and take it further?

Andreas Kling

Comment 8 2011-05-22 23:48:55 PDT

(In reply to comment #7) > There is no activity on this bug from a long time. So can I assign it to myself and take it further? Given that Noam is currently rewriting this code, I'd suggest you sync with him (noamr on #qtwebkit) :)

Noam Rosenthal

Comment 9 2011-05-22 23:50:25 PDT

*** This bug has been marked as a duplicate of bug 60842 ***

Note You need to log in before you can comment on or make changes to this bug.